mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-25 08:34:23 +00:00
3aa9f44d97
* H.A.R.S. no longer disables your skillchips (and also doesn't show you the brain-removal text) (#84841) ## About The Pull Request So, this one needs some explanation. First, how does H.A.R.S. work code wise? Well, it's pretty simple:7d7a6da735/code/datums/mutations/body.dm (L611-L613)It removes the victim's brain from their head and then immediately puts it back into their chest. It also sets that special flag to true. This is what the docs have to say about that flag:7d7a6da735/code/modules/surgery/organs/organ_movement.dm (L27)So basically, it suppresses the side effects of having the organ removed. This is why H.A.R.S. doesn't kill you instantly despite removing your brain. So why does still deactivate skillchips, since that's also a side effect? Well, that's because brain code doesn't actually take it into account properly:7d7a6da735/code/modules/mob/living/brain/brain_item.dm (L112-L119)Instead of treating the special flag as "should we prevent side effects?" It treats it as "should we make this silent?" So I just took the obvious route and changed that part. There was also another bug, where you'd be shown this text upon gaining or losing H.A.R.S.: > You feel slightly disoriented. That's normal when you're just a brain. That obviously shouldn't be happening, so I made H.A.R.S. pass `movement_flags = NO_ID_TRANSFER` as well. Fixes #84010 ## Why It's Good For The Game Bugfix. To know why I fixed the bug in this way specifically, see above. ## Changelog 🆑 fix: H.A.R.S. will no longer disable your skillchips or show you text reserved for total brain removal. /🆑 * H.A.R.S. no longer disables your skillchips (and also doesn't show you the brain-removal text) --------- Co-authored-by: GPeckman <21979502+GPeckman@users.noreply.github.com>