Bubberstation

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-01 04:21:42 +00:00

Files

SkyratBot 71aaef1632 [MIRROR] Fixes balloon alert runtime when finishing a mod suit [MDB IGNORE] (#20724 )

* Fixes balloon alert runtime when finishing a mod suit (#74891)

## About The Pull Request
Fixes this
![Screenshot
(175)](https://user-images.githubusercontent.com/110812394/233588431-20b69bd0-2bf0-4eae-bcdf-25674b1aa4c5.png)

Caused by this
![Screenshot
(176)](https://user-images.githubusercontent.com/110812394/233588470-8798a1e3-dfe8-4fbf-bfd3-989c3dec1617.png)

Which is caused when you finish a mod suit by adding plating to it. It
does not show up in the stack trace because
`/obj/item/mod/construction/shell ` is deleted when you add plating to
create the final mod suit.

6a83ad76e7/code/modules/mod/mod_construction.dm (L234-L238)

because the src is deleted, by the time balloon alert executes via async
it adds a timer on the deleted mod core causing the runtime.

## Changelog
🆑
fix: balloon alert adding timer on deleted mod core after construction
causing runtime.
/🆑

* Fixes balloon alert runtime when finishing a mod suit

---------

Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>

2023-04-23 21:48:07 -04:00

modules

[MIRROR] Audio File Cleanup [MDB IGNORE] (#20675 )

2023-04-21 17:22:11 -04:00

adding_new_mod.md

…

mod_actions.dm

[MIRROR] Fixes Ninjas not being able to use adrenaline while unconscious + code improvement [MDB IGNORE] (#19463 )

2023-03-10 04:20:33 +00:00

mod_activation.dm

[MIRROR] Fixes Ninjas not being able to use adrenaline while unconscious + code improvement [MDB IGNORE] (#19463 )

2023-03-10 04:20:33 +00:00