mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-19 19:18:50 +01:00
Watermelon914andShadow-Quill
79b00baad2
## About The Pull Request
As the title says.
`init_order` is no more, subsystems ordering now depends on their
declared dependencies.
Subsystems can now declare which other subsystems need to init before
them using a list and the subsystem's typepath
I.e.
```dm
dependencies = list(
/datum/controller/subsystem/atoms,
/datum/controller/subsystem/mapping
)
```
The reverse can also be done, if a subsystem must initialize after your
own:
```dm
dependents = list(
/datum/controller/subsystem/atoms
)
```
Cyclical dependencies are not allowed and will throw an error on
initialization if one is found.
There's also a debug tool to visualize the dependency graph, although
it's a bit basic:
Subsystem load ordering can still be controlled using `init_stage`, some
subsystems use this in cases where they must initialize first or last
regardless of dependencies. An error will be thrown if a subsystem has
an `init_stage` before one of their dependencies.
## Why It's Good For The Game
Makes dealing with subsystem dependencies easier, and reduces the chance
of making a dependency error when needing to shift around subsystem
inits.
## Changelog
🆑
refactor: Refactored subsystem initialization
/🆑
104 lines
3.6 KiB
Plaintext
104 lines
3.6 KiB
Plaintext
SUBSYSTEM_DEF(achievements)
|
|
name = "Achievements"
|
|
flags = SS_NO_FIRE
|
|
var/achievements_enabled = FALSE
|
|
|
|
///List of achievements
|
|
var/list/datum/award/achievement/achievements = list()
|
|
///The achievement with the highest amount of players that have unlocked it.
|
|
var/datum/award/achievement/most_unlocked_achievement
|
|
///List of scores
|
|
var/list/datum/award/score/scores = list()
|
|
///List of all awards
|
|
var/list/datum/award/awards = list()
|
|
|
|
/datum/controller/subsystem/achievements/Initialize()
|
|
if(!SSdbcore.Connect())
|
|
return SS_INIT_NO_NEED
|
|
achievements_enabled = TRUE
|
|
|
|
var/list/achievements_by_db_id = list()
|
|
for(var/datum/award/achievement/achievement as anything in subtypesof(/datum/award/achievement))
|
|
if(!initial(achievement.database_id)) // abstract type
|
|
continue
|
|
var/datum/award/achievement/instance = new achievement
|
|
achievements[achievement] = instance
|
|
awards[achievement] = instance
|
|
achievements_by_db_id[instance.database_id] = instance
|
|
|
|
for(var/datum/award/score/score as anything in subtypesof(/datum/award/score))
|
|
if(!initial(score.database_id)) // abstract type
|
|
continue
|
|
var/instance = new score
|
|
scores[score] = instance
|
|
awards[score] = instance
|
|
|
|
update_metadata()
|
|
|
|
/**
|
|
* Count how many (unlocked) achievements are in the achievements database
|
|
* then store that amount in the times_achieved variable for each achievement.
|
|
*
|
|
* Thanks to Jordie for the query.
|
|
*/
|
|
var/datum/db_query/query = SSdbcore.NewQuery(
|
|
"SELECT a.achievement_key, COUNT(a.achievement_key) AS count FROM achievements a \
|
|
JOIN achievement_metadata m ON a.achievement_key = m.achievement_key AND m.achievement_type = 'achievement' \
|
|
GROUP BY a.achievement_key ORDER BY count DESC"
|
|
)
|
|
if(query.Execute(async = TRUE))
|
|
while(query.NextRow())
|
|
var/id = query.item[1]
|
|
var/datum/award/achievement/instance = id ? achievements_by_db_id[id] : null
|
|
if(isnull(instance)) // removed achievement
|
|
continue
|
|
instance.times_achieved = query.item[2]
|
|
// the results are ordered in descending orders, so the first in the list should be the most unlocked one.
|
|
if(!most_unlocked_achievement)
|
|
most_unlocked_achievement = instance
|
|
qdel(query)
|
|
|
|
for(var/client/C in GLOB.clients)
|
|
if(!C.persistent_client.achievements.initialized)
|
|
C.persistent_client.achievements.InitializeData()
|
|
|
|
return SS_INIT_SUCCESS
|
|
|
|
/datum/controller/subsystem/achievements/Shutdown()
|
|
save_achievements_to_db()
|
|
|
|
/datum/controller/subsystem/achievements/proc/save_achievements_to_db()
|
|
var/list/cheevos_to_save = list()
|
|
for(var/ckey in GLOB.persistent_clients_by_ckey)
|
|
var/datum/persistent_client/PD = GLOB.persistent_clients_by_ckey[ckey]
|
|
if(!PD || !PD.achievements)
|
|
continue
|
|
cheevos_to_save += PD.achievements.get_changed_data()
|
|
|
|
if(!length(cheevos_to_save))
|
|
return
|
|
SSdbcore.MassInsert(format_table_name("achievements"), cheevos_to_save, duplicate_key = TRUE)
|
|
SEND_SIGNAL(src, COMSIG_ACHIEVEMENTS_SAVED_TO_DB)
|
|
|
|
//Update the metadata if any are behind
|
|
/datum/controller/subsystem/achievements/proc/update_metadata()
|
|
var/list/current_metadata = list()
|
|
//select metadata here
|
|
var/datum/db_query/Q = SSdbcore.NewQuery("SELECT achievement_key,achievement_version FROM [format_table_name("achievement_metadata")]")
|
|
if(!Q.Execute(async = TRUE))
|
|
qdel(Q)
|
|
return
|
|
else
|
|
while(Q.NextRow())
|
|
current_metadata[Q.item[1]] = text2num(Q.item[2])
|
|
qdel(Q)
|
|
|
|
var/list/to_update = list()
|
|
for(var/T in awards)
|
|
var/datum/award/A = awards[T]
|
|
if(!current_metadata[A.database_id] || current_metadata[A.database_id] < A.achievement_version)
|
|
to_update += list(A.get_metadata_row())
|
|
|
|
if(to_update.len)
|
|
SSdbcore.MassInsert(format_table_name("achievement_metadata"),to_update,duplicate_key = TRUE)
|