mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-07-25 06:56:53 +01:00
_0Steven
20ee6acdf8
## About The Pull Request So this is all because of a leftover bit making all fancy holders set their `max_slots` to the `spawn_count`, which of course would override the custom storage datums. https://github.com/tgstation/tgstation/blob/526e006583eee95d809b4062938072f78974ed78/code/game/objects/items/storage/fancy.dm#L33-L36 This just moves all of the fancy storage items away from auto-calculating storage based on those vars entirely, making new storage datums for all of the ones which didn't have one yet. We also move this out of the misc file, because a misc file is meaningless if everything together makes it bloated. We also do some minor fixes and changes. - The pickle jar could only hold seven small items, even though it'd take ten pickles, so we make it hold ten small items. - Coffee cartridge racks started with the sprite for 4 of them, so we make it start with the sprite for 1 of them. - Nugget fish in the bugget box :) - We make a few of the visual storages with even amounts above 7 split their storage up into two even rows, so their UI actually looks full when full. ## Why It's Good For The Game Less jank good 👍 It feels kinda awkward when you have a full box of stuff, visually full of stuff, and the storage UI is for a significant portion empty- but you can't put in more. This makes it so the full storage UI actually matches the object looking full. It's funny if Fryish, the nugget fish, can be stored in a nugget box. ## Changelog 🆑 balance: Egg boxes' storage UI is now 6 slots wide, such that it contains an even dozen slots when full. balance: The storage UIs for heart-shaped chocolate boxes, pickle jars, and rolling paper packs are now 4, 5, and 5 slots wide respectively, such that they fill the whole storage UI when full. balance: Fryish and its fried snack cousins can now be stored in nugget boxes. fix: Pickle jars can actually hold the ten pickles they spawn with. fix: Fertile egg boxes, coffee condiment displays, and coffee cart racks have the right amount of slots. fix: Coffee cart racks spawn with the sprite for holding 1 cartridge like they do, rather than looking like they're holding 4 cartridges. /🆑