mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-21 06:25:59 +00:00
8050627bba
## About The Pull Request Closes #79301 Saw this PR, realized how much this annoyed me whenever I played. Not a hard fix either, since RCD's were a perfect example. (In the future perhaps items that use upgrades like this could have one base type of disk, and a component for 'upgrade_disk_tool', but that's way, WAY out of my experience. Just something I noticed between the RPD and RCD disks.)  One on the Left already has the upgrade. Neither try to double-install it! (Shown for posterity) Ones on the right are installed both ways. One, the RPD on the Disk. The other, the Disk on the RPD! --- Actual PR changes: - New proc on the RPD called `install_upgrade()` - If the upgrade disk isn't installed, it installs it onto the RPD and deletes the disk. So, the same as the RCD one, but fewer checks since the RPD's got a lot fewer disks. But, easier to add new ones now. - Since `install_upgrade()` is a thing, the attack chain's code for how RPD's originally got upgraded is now much shorter. It still functions the same, though - nothing was removed in this PR! - Adds an attackby check - if the RPD's attacked by an upgrade disk it will try to `install_upgrade()`. So basically, what RCD's have. ## Why It's Good For The Game Consistency between the RPD and RCD upgrade-wise. The RPD's other method of installing (hitting the disk WITH the RPD) still works, but now players used to the RCD won't get confused. ## Changelog 🆑 qol: The RPD now accepts upgrade disks inserted by hand, as well as their original method of hitting the disk with the RPD /🆑 --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>