Files
Bubberstation/code/modules/hydroponics
Bloop 5e71657149 Fixes a runtime in seed extractor when seeds do not have a product (#78471)
## About The Pull Request

Fixes https://github.com/Skyrat-SS13/Skyrat-tg/issues/23819

I don't know whether or not this started before or after the foodening
but there were some logic errors in the seed extractor code.

1) Moved the logic around so that seeds will no longer get eaten by the
seed extractor if the `add_seed` proc returned false or null. It
shouldn't have been doing this to begin with.

2) Fixed a runtime that would cause `add_seed` to return null with a
runtime every time you tried to insert a seed without a `product`. (ex:
starthistle). This would in turn cause the seeds to be snatched from the
user's hand and put into the machine, making them essentially deleted.

## Why It's Good For The Game

Fixes more botany bugs. Yay...

Makes the seed extractor code a bit more robust as well.

<details><summary>Starthistle can be added</summary>


![image](https://github.com/tgstation/tgstation/assets/13398309/56e9b78a-08ca-4c67-8220-27974e242320)

</details>

<details><summary>Now let's try to get it to runtime and see what
happens</summary>


![dreamseeker_39LhTUCtWg](https://github.com/tgstation/tgstation/assets/13398309/83b20964-c2d4-4376-8ab5-86a8e430dafe)


![dreamseeker_eInEB47vPU](https://github.com/tgstation/tgstation/assets/13398309/384eab51-ef3a-4ae1-9cc7-c418e2aaf56b)

Yep. Still holding the seeds.

</details>

## Changelog

🆑
fix: Seeds will no longer be removed from existence after receiving the
"You can't seem to add [seed type] to the seed extractor" message
fix: Some seeds that were previously not able to be added to the seed
extractor may now be added (starthistle for example)
fix: fixes replica pod seeds spawning humans in nullspace
/🆑

edit: Includes the replica pod seed fix from
https://github.com/tgstation/tgstation/pull/78628 at the request of
Timothymtorres

---------

Co-authored-by: Tim <timothymtorres@gmail.com>
2023-09-27 11:01:35 +02:00
..
2023-08-31 14:57:19 -04:00
2023-08-31 14:57:19 -04:00