mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-18 13:04:45 +00:00
13cfcdad6b
## About The Pull Request So this just changes some instances of `key` to `ckey`. There is a reason for it I swear! So when ashwalkers get spawned their mob gets added to the `team.players_spawned` list via their `key` var. --- However, we have this as part of sacrifice code: Here the `deliverykey` var is set to `fingerprintslast`, which is a ckey.f6f6ebc276/code/modules/mapfluff/ruins/objects_and_mobs/ash_walker_den.dm (L79)f6f6ebc276/code/modules/forensics/_forensics.dm (L218)--- That `deliverykey` is then used to remove a ckey from the list heref6f6ebc276/code/modules/mapfluff/ruins/objects_and_mobs/ash_walker_den.dm (L84)Since `deliverkey` is a `ckey`, which is not always the same thing as the `key`, this can cause a mob to not get removed from the list properly if the two mismatch. ```(From DM Reference on `ckey`: "The key in canonical form. To do this, it strips all punctuation and space from the key and converts to lowercase. The result is still unique for each different key. ")``` I just think it's a bit confusing to switch back and forth, and it's unclear if it causes errors or not. This could be considered a code improvement I guess? Or a fix, depending. ## Why It's Good For The Game Less confusing, more consistent code. Less bugs. Much good. ## Changelog Nothing anyone shall ever notice besides the coders