mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-14 03:32:00 +00:00
067188d366
* Micro-optimize qdel by only permitting one parameter (#80628) Productionizes #80615. The core optimization is this: ```patch - var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up. + var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up. ``` We avoid a heap allocation in the form of copying the args over to a new list. A/B testing shows this results in 33% better overtime, and in a real round shaving off a full second of self time and 0.4 seconds of overtime--both of these would be doubled in the event this is merged as the new proc was only being run 50% of the time. * Micro-optimize qdel by only permitting one parameter --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
95 lines
3.6 KiB
Plaintext
95 lines
3.6 KiB
Plaintext
/**
|
|
* ## On Hit Effect Component!
|
|
*
|
|
* Component for other elements/components to rely on for on-hit effects without duplicating the on-hit code.
|
|
* See Lifesteal, or bane for examples.
|
|
*
|
|
* THIS COULD EASILY SUPPORT COMPONENT_DUPE_ALLOWED but the getcomponent makes it throw errors. if you can figure that out feel free to readd the dupe types
|
|
*/
|
|
/datum/component/on_hit_effect
|
|
///callback used by other components to apply effects
|
|
var/datum/callback/on_hit_callback
|
|
///callback optionally used for more checks
|
|
var/datum/callback/extra_check_callback
|
|
///optionally should we also apply the effect if thrown at something?
|
|
var/thrown_effect
|
|
|
|
/datum/component/on_hit_effect/Initialize(on_hit_callback, extra_check_callback, thrown_effect = FALSE)
|
|
src.on_hit_callback = on_hit_callback
|
|
src.extra_check_callback = extra_check_callback
|
|
if(!(ismachinery(parent) || isstructure(parent) || isgun(parent) || isprojectilespell(parent) || isitem(parent) || isanimal_or_basicmob(parent) || isprojectile(parent)))
|
|
return ELEMENT_INCOMPATIBLE
|
|
src.thrown_effect = thrown_effect
|
|
|
|
/datum/component/on_hit_effect/Destroy(force)
|
|
on_hit_callback = null
|
|
extra_check_callback = null
|
|
return ..()
|
|
|
|
/datum/component/on_hit_effect/RegisterWithParent()
|
|
if(ismachinery(parent) || isstructure(parent) || isgun(parent) || isprojectilespell(parent))
|
|
RegisterSignal(parent, COMSIG_PROJECTILE_ON_HIT, PROC_REF(on_projectile_hit))
|
|
else if(isitem(parent))
|
|
RegisterSignal(parent, COMSIG_ITEM_AFTERATTACK, PROC_REF(item_afterattack))
|
|
else if(isanimal_or_basicmob(parent))
|
|
RegisterSignal(parent, COMSIG_HOSTILE_POST_ATTACKINGTARGET, PROC_REF(hostile_attackingtarget))
|
|
else if(isprojectile(parent))
|
|
RegisterSignal(parent, COMSIG_PROJECTILE_SELF_ON_HIT, PROC_REF(on_projectile_self_hit))
|
|
|
|
if(thrown_effect)
|
|
RegisterSignal(parent, COMSIG_MOVABLE_IMPACT, PROC_REF(on_thrown_hit))
|
|
|
|
/datum/component/on_hit_effect/UnregisterFromParent()
|
|
UnregisterSignal(parent, list(
|
|
COMSIG_PROJECTILE_ON_HIT,
|
|
COMSIG_ITEM_AFTERATTACK,
|
|
COMSIG_HOSTILE_POST_ATTACKINGTARGET,
|
|
COMSIG_PROJECTILE_SELF_ON_HIT,
|
|
COMSIG_MOVABLE_IMPACT,
|
|
))
|
|
|
|
/datum/component/on_hit_effect/proc/item_afterattack(obj/item/source, atom/target, mob/user, proximity_flag, click_parameters)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!proximity_flag)
|
|
return
|
|
|
|
if(extra_check_callback)
|
|
if(!extra_check_callback.Invoke(user, target, source))
|
|
return
|
|
on_hit_callback.Invoke(source, user, target, user.zone_selected)
|
|
return COMPONENT_AFTERATTACK_PROCESSED_ITEM
|
|
|
|
/datum/component/on_hit_effect/proc/hostile_attackingtarget(mob/living/attacker, atom/target, success)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!success)
|
|
return
|
|
|
|
if(extra_check_callback)
|
|
if(!extra_check_callback.Invoke(attacker, target))
|
|
return
|
|
on_hit_callback.Invoke(attacker, attacker, target, attacker.zone_selected)
|
|
|
|
/datum/component/on_hit_effect/proc/on_projectile_hit(datum/fired_from, atom/movable/firer, atom/target, angle, body_zone)
|
|
SIGNAL_HANDLER
|
|
|
|
if(extra_check_callback)
|
|
if(!extra_check_callback.Invoke(firer, target))
|
|
return
|
|
on_hit_callback.Invoke(fired_from, firer, target, body_zone)
|
|
|
|
/datum/component/on_hit_effect/proc/on_projectile_self_hit(datum/source, mob/firer, atom/target, angle, body_zone)
|
|
SIGNAL_HANDLER
|
|
|
|
if(extra_check_callback)
|
|
if(!extra_check_callback.Invoke(firer, target))
|
|
return
|
|
on_hit_callback.Invoke(source, firer, target, body_zone)
|
|
|
|
/datum/component/on_hit_effect/proc/on_thrown_hit(datum/source, atom/hit_atom, datum/thrownthing/throwingdatum)
|
|
SIGNAL_HANDLER
|
|
if(extra_check_callback && !extra_check_callback.Invoke(source, hit_atom))
|
|
return
|
|
on_hit_callback.Invoke(source, source, hit_atom, null)
|