tonty 3f0b4abb8d Replaces world.icon_size (and some magic numbers) with defines (#86819) ...

## About The Pull Request

All usages of world.icon_size in code have been replaced with new
`ICONSIZE_X`, `ICONSIZE_Y` and `ICONSIZE_ALL` defines depending on
context

Replaces some "32" magic numbers with the defines

A few bits of code have been modified to split up x/y math as well

## Why It's Good For The Game

Magic number bad, code more readable, code more flexible and I'm told
there's an access cost to doing world.icon_size so minor performance
gains

## Changelog

🆑 tonty
code: made some code relating to the world's icon size more readable
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>

2024-09-29 13:28:32 +00:00

..

AI_modules

Audits tgui_input_text() for length issues (#86741)

2024-09-20 22:46:41 +00:00

circuitboards

adds some "factory" machines (#86063)

2024-09-29 14:58:27 +02:00

devices

Reduces volume of the nuke sound (#86888)

2024-09-27 16:33:45 +02:00

food

Replaces world.icon_size (and some magic numbers) with defines (#86819)

2024-09-29 13:28:32 +00:00

granters

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

grenades

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

implants

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

kirby_plants

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

melee

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

rcd

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

robot

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

stacks

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

storage

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

tanks

Spacemove refactor - Newtonian physics (#84869)

2024-09-26 02:49:54 -07:00

tcg

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

tools

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

airlock_painter.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

apc_frame.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

bear_armor.dm

Spelling and Grammar Fixes (#86022)

2024-08-23 21:49:46 +02:00

binoculars.dm

…

blueprints.dm

…

body_egg.dm

Death of mutant bodyparts AND external organs (#85137)

2024-08-20 16:33:34 +02:00

bodybag.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

botpad_remote.dm

…

boxcutter.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

broom.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

busts_and_figurines.dm

…

cardboard_cutouts.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

cards_ids.dm

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

chainsaw.dm

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

charter.dm

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

choice_beacon.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

chromosome.dm

Spelling and Grammar Fixes (#86022)

2024-08-23 21:49:46 +02:00

cigarettes.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

climbingrope.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

clown_items.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

control_wand.dm

Storage / table interactions at the bottom of the interaction chain (#85512)

2024-09-12 23:48:19 +02:00

cosmetics.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

courtroom.dm

…

crab17.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

crayons.dm

Replaces world.icon_size (and some magic numbers) with defines (#86819)

2024-09-29 13:28:32 +00:00

credit_holochip.dm

…

debug_items.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

defib.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

dehy_carp.dm

…

dice.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

dna_injector.dm

…

dna_probe.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

door_seal.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

drug_items.dm

…

dualsaber.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

dyespray.dm

…

eightball.dm

Audits tgui_input_text() for length issues (#86741)

2024-09-20 22:46:41 +00:00

emags.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

etherealdiscoball.dm

Removes caps from many improper items (#86759)

2024-09-21 00:09:34 +02:00

extinguisher.dm

Spacemove refactor - Newtonian physics (#84869)

2024-09-26 02:49:54 -07:00

fireaxe.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

flamethrower.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

frog_statue.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

gift.dm

…

gun_maintenance.dm

…

hand_items.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

handcuffs.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

his_grace.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

holosign_creator.dm

…

hot_potato.dm

…

hourglass.dm

…

inducer.dm

Doubles PACMAN power output, triples their sheet efficiency. Inducers can now be recharged with plasma. (#85950)

2024-08-19 13:15:57 +02:00

inspector.dm

Nobody expects the span inquisition: replaces most <span>s with macros (#86798)

2024-09-26 19:36:13 +00:00

janitor_key.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

kitchen.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

knives.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

latexballoon.dm

…

lighter.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

machine_wand.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

mail.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

maintenance_loot.dm

Lead pipe readjustments (#86835)

2024-09-26 19:25:11 +00:00

manuals.dm

…

mop.dm

…

paint.dm

event based incapicated and able_to_run (#86031)

2024-09-04 10:02:49 -04:00

paiwire.dm

…

pet_carrier.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

piggy_bank.dm

…

pillow.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

pinpointer.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

pitchfork.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

plushes.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

pneumaticCannon.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

powerfist.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

puzzle_pieces.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

religion.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

rollertable_dock.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

scrolls.dm

event based incapicated and able_to_run (#86031)

2024-09-04 10:02:49 -04:00

secret_documents.dm

…

sharpener.dm

…

shields.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

shooting_range.dm

Wallening Revert [MDB Ignore][IDB Ignore] (#86161)

2024-09-03 10:41:51 +02:00

shrapnel.dm

…

signs.dm

…

skub.dm

…

spear.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

stickers.dm

Fixes xenos being able to pick up items that they shouldn't by most means, expands itempicky component functionality (#86714)

2024-09-18 23:38:07 +02:00

surgery_tray.dm

…

syndie_spraycan.dm

Refactors creampies and face paint into a single face_decal component (#86014)

2024-08-25 20:07:58 -06:00

tail_pin.dm

Replaces world.icon_size (and some magic numbers) with defines (#86819)

2024-09-29 13:28:32 +00:00

taster.dm

Storage / table interactions at the bottom of the interaction chain (#85512)

2024-09-12 23:48:19 +02:00

teleportation.dm

Polished Syndicate Teleporter effects (#86807)

2024-09-29 00:58:02 +02:00

theft_tools.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

tongs.dm

…

toy_mechs.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00

toys.dm

Replaces world.icon_size (and some magic numbers) with defines (#86819)

2024-09-29 13:28:32 +00:00

trash.dm

Reintroducing my PRs that were lost in the wallening revert. (#86439)

2024-09-04 06:50:04 -04:00

v8_engine.dm

…

vending_items.dm

…

virgin_mary.dm

…

wall_mounted.dm

[NO GBP] Fixes wallmounts not being mountable by using a screwdriver on them (#86768)

2024-09-21 00:10:12 +02:00

weaponry.dm

Replaces world.icon_size (and some magic numbers) with defines (#86819)

2024-09-29 13:28:32 +00:00

wiki_manuals.dm

Fix guide books that rely on the wiki (#86891)

2024-09-29 00:03:47 +02:00

wizard_weapons.dm

Reorganizes the sound folder (#86726)

2024-09-23 22:24:50 -07:00