mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-18 04:55:27 +00:00
ccef887efe
# MAINTAINER - USE THE BUTTON THAT SAYS "MERGE MASTER" THEN SET THE PR TO AUTO-MERGE! IT'S MUCH EASIER FOR ME TO FIX THINGS BEFORE THEY SKEW RATHER THAN AFTER THE FACT. ## About The Pull Request Hey there, This took a while to do, but here's the gist: Python file now regexes every file in `/code` except for those that have some valid reason to be tacking on more global defines. Some of those reasons are simply just that I don't have the time right now (doing what you see in this PR took a few hours) to refactor and parse what should belong and what should be thrown out. For the time being though, this PR will at least _halt_ people making the mistake of not `#undef`ing any files they `#define` "locally", or within the scope of a file. Most people forget to do this and this leads to a lot of mess later on due to how many variables can be unmanaged on the global level. I've made this mistake, you've made this mistake, it's a common thing. Let's automatically check for it so it can be fixed no-stress. Scenarios this PR corrects: * Forgetting to undef a define but undeffing others. * Not undeffing any defines in your file. * Earmarking a define as a "file local" define, but not defining it. * Having a define be a "file local" define, but having it be used elsewhere. * Having a "local" define not even be in the file that it only shows up in. * Having a completely unused define* (* I kept some of these because they seemed important... Others were junked.) ## Why It's Good For The Game If you wanna use it across multiple files, no reason to not make it a global define (maybe there's a few reasons but let's assume that this is the 95% case). Let me know if you don't like how I re-arranged some of the defines and how you'd rather see it be implemented, and I'd be happy to do that. This was mostly just "eh does it need it or not" sorta stuff. I used a pretty cool way to detect if we should use the standardized GitHub "error" output, you can see the results of that here https://github.com/san7890/bruhstation/actions/runs/4549766579/jobs/8022186846#step:7:792 ## Changelog Nothing that really concerns players. (I fixed up all this stuff using vscode, no regexes beyond what you see in the python script. sorry downstreams)
67 lines
3.0 KiB
Plaintext
67 lines
3.0 KiB
Plaintext
// The severity of explosions. Why are these inverted? I have no idea, but git blame doesn't go back far enough for me to find out.
|
|
/// The (current) highest possible explosion severity.
|
|
#define EXPLODE_DEVASTATE 3
|
|
/// The (current) middling explosion severity.
|
|
#define EXPLODE_HEAVY 2
|
|
/// The (current) lowest possible explosion severity.
|
|
#define EXPLODE_LIGHT 1
|
|
/// The default explosion severity used to mark that an object is beyond the impact range of the explosion.
|
|
#define EXPLODE_NONE 0
|
|
|
|
//gibtonite state defines
|
|
/// Gibtonite has not been mined
|
|
#define GIBTONITE_UNSTRUCK 0
|
|
/// Gibtonite has been mined and will explode soon
|
|
#define GIBTONITE_ACTIVE 1
|
|
/// Gibtonite has been stablized preventing an explosion
|
|
#define GIBTONITE_STABLE 2
|
|
/// Gibtonite will now explode
|
|
#define GIBTONITE_DETONATE 3
|
|
|
|
/// A wrapper for [/atom/proc/ex_act] to ensure that the explosion propagation and attendant signal are always handled.
|
|
#define EX_ACT(target, args...)\
|
|
if(!(target.flags_1 & PREVENT_CONTENTS_EXPLOSION_1)) { \
|
|
target.contents_explosion(##args);\
|
|
};\
|
|
SEND_SIGNAL(target, COMSIG_ATOM_EX_ACT, ##args);\
|
|
target.ex_act(##args);
|
|
|
|
// Internal explosion argument list keys.
|
|
// Must match the arguments to [/datum/controller/subsystem/explosions/proc/propagate_blastwave]
|
|
/// The origin atom of the explosion.
|
|
#define EXARG_KEY_ORIGIN "origin"
|
|
/// The potential cause of the explosion, if different to origin.
|
|
#define EXARG_KEY_EXPLOSION_CAUSE STRINGIFY(explosion_cause)
|
|
/// The devastation range of the explosion.
|
|
#define EXARG_KEY_DEV_RANGE STRINGIFY(devastation_range)
|
|
/// The heavy impact range of the explosion.
|
|
#define EXARG_KEY_HEAVY_RANGE STRINGIFY(heavy_impact_range)
|
|
/// The light impact range of the explosion.
|
|
#define EXARG_KEY_LIGHT_RANGE STRINGIFY(light_impact_range)
|
|
/// The flame range of the explosion.
|
|
#define EXARG_KEY_FLAME_RANGE STRINGIFY(flame_range)
|
|
/// The flash range of the explosion.
|
|
#define EXARG_KEY_FLASH_RANGE STRINGIFY(flash_range)
|
|
/// Whether or not the explosion should be logged.
|
|
#define EXARG_KEY_ADMIN_LOG STRINGIFY(adminlog)
|
|
/// Whether or not the explosion should ignore the bombcap.
|
|
#define EXARG_KEY_IGNORE_CAP STRINGIFY(ignorecap)
|
|
/// Whether or not the explosion should produce sound effects and screenshake if it is large enough to warrant it.
|
|
#define EXARG_KEY_SILENT STRINGIFY(silent)
|
|
/// Whether or not the explosion should produce smoke if it is large enough to warrant it.
|
|
#define EXARG_KEY_SMOKE STRINGIFY(smoke)
|
|
|
|
// Explodable component deletion values
|
|
/// Makes the explodable component queue to reset its exploding status when it detonates.
|
|
#define EXPLODABLE_NO_DELETE 0
|
|
/// Makes the explodable component delete itself when it detonates.
|
|
#define EXPLODABLE_DELETE_SELF 1
|
|
/// Makes the explodable component delete its parent when it detonates.
|
|
#define EXPLODABLE_DELETE_PARENT 2
|
|
|
|
// Flags for [/obj/item/grenade/var/dud_flags]
|
|
/// The grenade cannot detonate at all. It is innately nonfunctional.
|
|
#define GRENADE_DUD (1<<0)
|
|
/// The grenade has been used and as such cannot detonate.
|
|
#define GRENADE_USED (1<<1)
|