mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-22 23:15:13 +00:00
dafef2aa4d
## About The Pull Request `/datum/ui_state/new_player_state` now no longer lets users with R_ADMIN permission see the UI. Changed `/datum/interview` to return always_state when an admin watches an interview because it is important there. `/datum/latejoin_menu` now uses new_player_state instead of its own solution. ## Why It's Good For The Game `/datum/ui_state/new_player_state` is designed to let lobby players interact with the UI, so it does not make sense for it to make a weird exception for admins too. My theory is that this was an oversight when this was first implemented, since only `/datum/interview` used this ui_state. It doesn't and it shouldn't be like this though. Code clarity. ## Changelog No playerfacing changes.
11 lines
293 B
Plaintext
11 lines
293 B
Plaintext
/**
|
|
* tgui state: new_player_state
|
|
*
|
|
* Checks that the user is a /mob/dead/new_player
|
|
*/
|
|
|
|
GLOBAL_DATUM_INIT(new_player_state, /datum/ui_state/new_player_state, new)
|
|
|
|
/datum/ui_state/new_player_state/can_use_topic(src_object, mob/user)
|
|
return isnewplayer(user) ? UI_INTERACTIVE : UI_CLOSE
|