mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-18 21:15:21 +00:00
ff4dcc1c53
## About The Pull Request This PR will add new (antag) device, that will allow players to counterfeit mails, putting (almost) anything they want and arming it, if they liked to. Upon activation this device will give you multiple choices like: - Is it gonna be an envelope or a normal mail? - Is it gonna be armed? - Who is gonna be a recipient? - If it is a non private mail, then what title it is gonna have? Those devices can put any single normal sized item inside a mail, that is gonna be activated upon opening if mail armed. Mail creator and other ditalis will be shown to admins upon activation for admin purposes. By activation i mean `attack_self` proc of an item. Armed mail can be disarmed by using, BUT! Only owner can disarm it with 100% success rate. Other people will have 50% chance of fail, that will activate a trap. Those devices also have few more admin-only variations: ``` /obj/item/storage/mail_counterfeit_device/advanced /obj/item/storage/mail_counterfeit_device/bluespace ``` They can put more items inside a mail. ### How to get those naughty devices? - Those devices can be purchased in uplink. One device goes for one TC. - QM and Cargo Technicians have special kits that costs 2 TC and have 6 devices. And yeah, i also fixed issue with envelopes, they actually have 2 items inside, but player were given only first one. Proof of testing:  (minibomb was set to instant detonation before recording) ## Why It's Good For The Game This PR will give a lot of new possibilities for traitors. Those mails can be used not only as bombing tools, but also for contraband and other purposes. Also those mails can be used for (b)admin stuff. ## Changelog 🆑 add: added a mail counterfeit device that can make custom (and also armed) mails. Traitors have those devices in their uplinks. add: added new kit for QM and Cargo Technicians that have multiple mail counterfeit devices for neat price. fix: fixed envelopes that were giving only their first item, even tho they had two items insede. image: added new icon for mail counterfeit device. /🆑 --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
11 lines
582 B
Plaintext
11 lines
582 B
Plaintext
/// Makes sure that fake mail doesn't get random goods.
|
|
/datum/unit_test/traitor_mail_content_check
|
|
|
|
/datum/unit_test/traitor_mail_content_check/Run()
|
|
var/mob/living/carbon/human/person = allocate(/mob/living/carbon/human/consistent)
|
|
person.mind_initialize()
|
|
var/obj/item/mail/traitor/test_mail = allocate(/obj/item/mail/traitor)
|
|
person.mind.set_assigned_role(SSjob.GetJobType(/datum/job/captain))
|
|
test_mail.initialize_for_recipient(person.mind)
|
|
TEST_ASSERT_EQUAL(test_mail.contents.len, 0, "/obj/item/mail/traitor should not have items after initialize_for_recipient proc!")
|