mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-23 15:38:08 +00:00
3b695cf65e
* Ground sinking sanity checks and doc cleanup (#79214) ## About The Pull Request The asynchronous sinking component of garden gnomes did not check if the gnome still existed, when the sinking timer ran out, which caused null exception runtimes. I have added sanity checks to this. In addition, the sinking used do_after, but failing the do_after had no effect on anything, and infact, made the mob sink even faster into the ground, so I have added an early return, and a call for unsinking. Also tweaked proc names and documentation. Funny story: the only reason I have found out about this bug is because sometimes garden gnomes spawn on a downstream map, and they cause a CI failure when the nuke cinematic unit test explodes them. 😔 ## Why It's Good For The Game Runtimes bad. Also if an action has a do_after call, it should probably fail if it the timer fails. ## Changelog 🆑 fix: Gnomes no longer runtime if they explode while sinking into the ground /🆑 * Ground sinking sanity checks and doc cleanup --------- Co-authored-by: Profakos <profakos@gmail.com>