mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-29 02:51:41 +00:00
2f291c7ea1
* Reworks blood deficiency backend, & some adjustments to slime blood deficiency * Update jellypeople.dm * e * wew * https://github.com/tgstation/tgstation/pull/74246 Co-Authored-By: san7890 <the@san7890.com> * https://github.com/tgstation/tgstation/pull/74189 I was looking over https://github.com/tgstation/tgstation/pull/74143 one last time as I tend to do with merged PR's and noticed a couple of nitpicky comment formatting things that will grate on me. Sorry about this @san7890 Edit: Then even worse I found a bug. Roundstart species with blood deficiency should now get the appropriate blood pack mail goodies sent to them. I had completely forgotten about ethereals. Code is a bit cleaner too. Fixes bug, dmdoc formatting 🆑 fix: fixed blood deficiency quirk sending the wrong blood pack to roundstart species who have exotic blood /🆑 Co-Authored-By: san7890 <the@san7890.com> * https://github.com/tgstation/tgstation/pull/74229 Followup to #74189 What it says on the tin. This is the last time I will ping you on a blood-deficiency related PR, I swear! @san7890 About lizards--they have a special bloodtype that isn't compatible with the generic O- that gets sent to everyone else, which I am just now realizing. I also realized that there is never a situation when `on_species_loss` gets called without `on_species_gain` so there is no reason to call `update_mail_goodies` in each of those. I deleted the extra proc calls in `on_species_loss` to save on performance. Also cleans up some single letter vars in the lizard species file. Fixes an oversight, cleans up some code. 🆑 qol: lizards with blood deficiency now receive the type 'L' blood packs instead of an unhelpful type 'O-' one. /🆑 Co-Authored-By: san7890 <the@san7890.com> --------- Co-authored-by: Bloop <vinylspiders@gmail.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com> Co-authored-by: san7890 <the@san7890.com>