mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-29 02:51:41 +00:00
10f65497e1
* Splits Pirates into Two Subgroups, One For Light Midrounds And Another For Heavy (#73881) ## About The Pull Request This PR splits the Pirate midround antagonists into two separate groups, normal and dangerous. Normal pirates are the human, silverscale, and psycker groups, and they are all light antagonists now, meaning they can show up early in the round, similar to when a revenant or nightmare can spawn. Dangerous Space Pirates only consist of the Skeleton Crew, and they will remain as heavy weight antagonists with the same spawning restrictions as it is currently. I also fudged with the crew required value some for both, not that it makes a huge difference. Since pirates were split into two separate groups, both versions have a reduced dynamic weight of 3, from 4. Also added a sanity check to the pirate's dynamic ruleset to make sure there are remaining pirates to be spawned for the ruleset to be allowed. Also added a check to the pirate event itself to prevent runtimes when no pirate team is available to be chosen, unless an admin specifies what pirate team they want to use. ## Why It's Good For The Game As it is right now, there is a massive difference between the skeleton pirates and the rest of the pirate types. Skeleton Pirates have cannons, innate space immunity and other small benefits which make them much more threatening than the other pirate crews. In our current system, something like Psycker pirates can spawn in lieu of something like blob or xenomorphs when they aren't anywhere near the same level of threatening, so moving the less dangerous pirates off to be light weight midrounds seems like a good move, especially since we need more lightweight midrounds to keep the variety up anyway. Keep in mind these designations are not permanent and may change at the request of maintainers or as the pirate teams get nerfed/buffed. ## Changelog 🆑 balance: The pirate gangs have been split into two subcategories, one which can spawn earlier in a shift and one that spawns later as they currently do. While skeleton pirates will still be only seen later into the shift, expect to see the other pirate gangs earlier on. fix: Prevented the pirate event from runtiming when no possible pirate gangs were available. fix: Pirates can no longer be selected by Dynamic if there are no more pirates gangs that can be used. /🆑 * Splits Pirates into Two Subgroups, One For Light Midrounds And Another For Heavy --------- Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>