SkyratBot a788a19c72 [MIRROR] Fix durand shield overlay and light runtimes [MDB IGNORE] (#19374) ...

* Fix durand shield overlay and light runtimes (#73411)

## About The Pull Request
The Durand shield overlay would not be placed on top when facing south
due to the planes not being set properly. My changes update the planes
whenever the dir gets updated.

There was also a lighting runtime due to using the wrong lighting proc
call that would throw this error:

```
/atom/proc/update_light()
	SHOULD_NOT_SLEEP(TRUE)

	if(light_system != STATIC_LIGHT)
		CRASH("update_light() for [src] with following light_system value: [light_system]")
```

Someone mixed up the lighting code since `set_light()` is meant to be
used by `STATIC_LIGHT` sources. The durand shield lighting source is
`MOVABLE_LIGHT`.

All I needed to do was remove the extra procs since we already have
`set_light_on(chassis.defense_mode)` that controls the `MOVABLE_LIGHT`.
Basically, someone added two different lighting systems to the same
object, so big oof.

## Why It's Good For The Game
Better mech visuals and one less runtime.

<details>
<summary>Before:</summary>

![dreamseeker_yKywMgB7j3](https://user-images.githubusercontent.com/5195984/218541070-277af6c5-facb-48c1-bf73-ef51a1e6b0e2.gif)

</details>

<details>
<summary>After:</summary>

![dreamseeker_n94xpvzJyU](https://user-images.githubusercontent.com/5195984/218541159-b37dd33b-a3b3-411d-9704-f9be1efaf6aa.gif)

</details>

## Changelog
🆑
fix: Fix durand shield overlay to appear above the mech when facing
south. Also fixed a lighting runtime when shield would turn on/off.
/🆑

* Fix durand shield overlay and light runtimes

---------

Co-authored-by: Tim <timothymtorres@gmail.com>

2023-03-10 02:40:07 +00:00

..

durand.dm

[MIRROR] Fix durand shield overlay and light runtimes [MDB IGNORE] (#19374)

2023-03-10 02:40:07 +00:00

gygax.dm

…

honker.dm

…

marauder.dm

…

phazon.dm

…

reticence.dm

…

savannah_ivanov.dm

…