Files
Bubberstation/code/datums
SkyratBot 2c6fc5c946 [MIRROR] Fixes prosthetic limbs leaving the old one behind [MDB IGNORE] (#20987)
* Fixes prosthetic limbs leaving the old one behind (#75176)

## About The Pull Request

Fixes #75153
Caused by #75050

`Note: the old limb gets sent to nullspace during try_attach_limb`
...This assertion is completely wrong, and I'm not sure where it came
from. Perhaps it's different on their downstream.

`try_attach_limb` does not care about limbs that occupy the same body
zone and will happy attach itself, giving you two left arms or two right
legs.

`del_and_replace_bodypart` handles this by deleting the existing limb,
`return_and_replace_bodypart` did not handle this whatsoever. So I added
that missing handling.

I'm not sure if we *actually want* `try_attach_limb` to disregard limbs
that occupy that slot already. It seems like weird behavior but also
consumers should probably know what they're doing in regards to that?

While I was here, I made both prosthetic related quirks use `special =
TRUE`. The application of these limbs are supposed to be quick swapping
no-side-effects, since it's done at mob creation, so it should be using
special.

## Why It's Good For The Game

Three arms is bad, okay?

## Changelog

🆑 Melbert
fix: Fixed Prosthetic Quirk not removing the limb before giving the
prosthetic
/🆑

* Fixes prosthetic limbs leaving the old one behind

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2023-05-08 03:03:07 +01:00
..