Files
Bubberstation/code/datums/components
SkyratBot ac2b1d5ec7 [MIRROR] Restores Spell Card targetting behaviour [MDB IGNORE] (#19776)
* Restores Spell Card targetting behaviour (#73706)

## About The Pull Request

Fixes #52946

This has been broken ever since #44112 which apparently removed the proc
in this component which selected a target for performance reasons and
just... didn't replace it with anything else? So it's been bricked ever
since.

In order to restore the removed mouse tracking behaviour I implemented
the pattern used in scoped weapons and the kinesis module. As this was
the third thing I could find to use this code, I abstracted it out into
an object where most of the shared behaviour lives. I tested those
things too and they still seem to do what they used to.

Here it is in action:

https://user-images.githubusercontent.com/7483112/221954852-22244bb1-7c87-452d-a9b0-ebed81c4c1ef.mp4

Because this spell now applies a full screen overlay in order to
function, it's really begging for someone to make some touhou-style art
with cards and patterns around the edge of the screen while you are in
aiming mode, but I'm not going to be the one to make it.

I tidied this component up and refactored it as best I could while I was
reworking it to use a full screen overlay but I am... not totally
confident that it should be a component at all given that it keeps being
created and destroyed. But also it has worked that way for like four
years now, so who am I to say.

Oh yeah also the icon for this spell broke, so I fixed it.

## Why It's Good For The Game

Makes a reasonably terrible wizard spell marginally less bad.
Maybe now that this component works, some other things can use it?
If we make a fourth thing which follows your cursor it won't need to
copy/paste code around.

## Changelog

🆑
fix: Spell Cards from the Wizard spell will now home in somewhat on the
target nearest to your cursor.
fix: The Spell Cards spell now displays the correct icon instead of a
big red "error" text.
/🆑

* Restores Spell Card targetting behaviour

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2023-03-11 15:15:26 +00:00
..
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2023-01-24 14:27:00 -08:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00
2022-11-15 06:59:06 +00:00

Datum Component System (DCS)

Concept

Loosely adapted from /vg/. This is an entity component system for adding behaviours to datums when inheritance doesn't quite cut it. By using signals and events instead of direct inheritance, you can inject behaviours without hacky overloads. It requires a different method of thinking, but is not hard to use correctly. If a behaviour can have application across more than one thing. Make it generic, make it a component. Atom/mob/obj event? Give it a signal, and forward it's arguments with a SendSignal() call. Now every component that want's to can also know about this happening.

HackMD page for an introduction to the system as a whole.

See/Define signals and their arguments in __DEFINES\components.dm