Files
Bubberstation/code/modules/tgui_input
SkyratBot 6eb14f1d54 [MIRROR] Nullchecks Client on tgui_alert() and siblings [MDB IGNORE] (#24703)
* Nullchecks Client on `tgui_alert()` and siblings (#79322)

## About The Pull Request

Fixes #79321

```dm
/datum/tgui/proc/open()
	if(!user.client)
		return FALSE
```
The TGUI window won't even `open()` and do any work if we don't have a
client, so let's just explicitly get the hell out of dodge if we don't
have a client associated with a mob in these procs. Adding a `?` to
handle the runtime in the linked issue only obfuscates the deeper issue
because of the aforementioned code snippet.

## Why It's Good For The Game

Clientless monkeys will still somehow be able to interact with stuff
through their random behavior, and this is still plausible enough to
show up on live servers every so often, so let's just patch it out
early. These alerts are meant for player user input, so if we don't have
a player, let's bounce.
## Changelog
A player would never ever notice this.

* Nullchecks Client on `tgui_alert()` and siblings

---------

Co-authored-by: san7890 <the@san7890.com>
2023-10-31 21:16:06 -04:00
..