mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
47d1f9fc6d
* Fixing fish hook exploits, bait not being consumed, race conditions and achievement (#78302) ## About The Pull Request The bait wasn't being consumed properly because it was badly coded. Whoopsies. The achievement would be unlocked upon gaining legendary rank ONLY IF you won the minigame. My bad. Upon win (and loss), the fishing minigame would often be prematurely closed before ui act could run due to internal calls to do that. A classic example of race condition. Last but not least, the fishing hook exploit that would allow items to be in multiple places, including nullspace, and cause a load of issues. ## Why It's Good For The Game This PR should fix all of them. Closes #78210, closes #78204, closes #78187, closes #77265, closes #77265, closes #73014. ## Changelog 🆑 fix: Fixed a race condition that made fishing yield no reward way too often. fix: The legendary fisher achievement is awarded even if you don't win the minigame. fix: Fixed a fish hook exploit. fix: Baits are now properly consumed by caught fish and (alive) mobs. /🆑 * Fixing fish hook exploits, bait not being consumed, race conditions and achievement --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>