mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-27 17:41:50 +00:00
013dd62200
## About The Pull Request Ever since https://github.com/tgstation/tgstation/pull/91920 we have been getting a very persistent CI failure downstream, and upon investigating the transitions of this map seem weird and cut off, almost like it's taking pieces of the other side and trying to superimpose them on itself. <img width="1988" height="155" alt="image" src="https://github.com/user-attachments/assets/8533f966-2ccd-4e04-8855-384efc9a6e39" /> I looked at what it changed, and this line stuck out to me as suspicious. <img width="757" height="263" alt="image" src="https://github.com/user-attachments/assets/79994a3a-1208-49ca-8bfa-280d0c953c71" /> It stuck out to me because it seems like it might not appropriately handle space maps that have terrain near the borders (we have a map that is surrounded by an asteroid field, for instance, and that's the one that's been causing issues). <details><summary>Asteroid field map shown here</summary> <img width="873" height="801" alt="StrongDMM_BP2oO3sKtf" src="https://github.com/user-attachments/assets/d177cc89-de9f-4a93-8844-0aa2447edba6" /> </details> ~~@Time-Green Do you have any insights to this?~~ ~~I am drafting it for now because I don't think this is the right 'fix' as it will likely interfere with/break the icebox wilderness stuff.~~ ~~The main issue is (possibly?) that `atom/movable`s (including these rocks) which end up on the border of the map transition are being yeeted into space, on the opposite end of the map, because of their location.~~ ~~Movables that are maploaded probably shouldn't be transitioned, might be the solution there?~~ EDIT: Fairly certain that the issue has been found out, it's due to movable rocks which are mapped near the edge of the map getting instantly teleported upon maploading. Seems like this is something we should prevent from happening. ## Why It's Good For The Game Fixes an oversight ## Changelog Not player-facing