mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-28 01:51:46 +00:00
16d80d9be0
## About The Pull Request The issue was threefold, first speed potions sent the comsig before actually applying which could be abused to make items not have a slowdown without spending it or coloring them by using it on them in a state when they don't have a slowdown (i.e. disabled magboots). Magboots ``initial()``'d their slowdown which could break them if they somehow got it negative, but I believe that didn't happen in actual gameplay. And I've made duffelbags and laptops have their open slowdown set to 0 similarly to magboots when a speed potion is applied to them. Last one may be a balance change, depending on the original intent, but I'm going off their pre-rework behavior here (and it generally feels weird to be the case when they get unslowdowned and then it gets reapplied when you close and open them) - Closes #91381 ## Changelog 🆑 fix: Fixed speed potions behaving super inconsistently on magboots, duffelbags and laptops /🆑
140 lines
3.8 KiB
Plaintext
140 lines
3.8 KiB
Plaintext
/obj/item/modular_computer/laptop
|
|
name = "laptop"
|
|
desc = "A portable laptop computer."
|
|
|
|
icon = 'icons/obj/devices/modular_laptop.dmi'
|
|
icon_state = "laptop-closed"
|
|
icon_state_powered = "laptop"
|
|
icon_state_unpowered = "laptop-off"
|
|
icon_state_menu = "menu"
|
|
|
|
hardware_flag = PROGRAM_LAPTOP
|
|
max_idle_programs = 3
|
|
w_class = WEIGHT_CLASS_NORMAL
|
|
interaction_flags_mouse_drop = NEED_HANDS
|
|
|
|
|
|
// No running around with open laptops in hands.
|
|
item_flags = SLOWS_WHILE_IN_HAND
|
|
|
|
drag_slowdown = 0
|
|
screen_on = FALSE // Starts closed
|
|
var/start_open = TRUE // unless this var is set to 1
|
|
var/icon_state_closed = "laptop-closed"
|
|
var/w_class_open = WEIGHT_CLASS_BULKY
|
|
var/slowdown_open = 1
|
|
|
|
/obj/item/modular_computer/laptop/Initialize(mapload)
|
|
. = ..()
|
|
if(start_open && !screen_on)
|
|
toggle_open()
|
|
RegisterSignal(src, COMSIG_SPEED_POTION_APPLIED, PROC_REF(on_speed_potioned))
|
|
|
|
/obj/item/modular_computer/laptop/examine(mob/user)
|
|
. = ..()
|
|
if(screen_on)
|
|
. += span_notice("Alt-click to close it.")
|
|
|
|
/obj/item/modular_computer/laptop/add_context(atom/source, list/context, obj/item/held_item, mob/living/user)
|
|
. = ..()
|
|
if(screen_on)
|
|
context[SCREENTIP_CONTEXT_ALT_LMB] = "Close"
|
|
context[SCREENTIP_CONTEXT_RMB] = "Interact"
|
|
else
|
|
context[SCREENTIP_CONTEXT_RMB] = "Open"
|
|
|
|
return CONTEXTUAL_SCREENTIP_SET
|
|
|
|
/// Signal handler for [COMSIG_SPEED_POTION_APPLIED]. Speed potion removes the open slowdown
|
|
/obj/item/modular_computer/laptop/proc/on_speed_potioned(datum/source)
|
|
SIGNAL_HANDLER
|
|
// Don't need to touch the actual slowdown here, since the speed potion does it for us
|
|
slowdown_open = 0
|
|
|
|
/obj/item/modular_computer/laptop/update_icon_state()
|
|
if(!screen_on)
|
|
icon_state = icon_state_closed
|
|
return
|
|
return ..()
|
|
|
|
/obj/item/modular_computer/laptop/update_overlays()
|
|
if(!screen_on)
|
|
cut_overlays()
|
|
return
|
|
return ..()
|
|
|
|
/obj/item/modular_computer/laptop/attack_self(mob/user)
|
|
if(!screen_on)
|
|
try_toggle_open(user)
|
|
else
|
|
return ..()
|
|
|
|
/obj/item/modular_computer/laptop/verb/open_computer()
|
|
set name = "Toggle Open"
|
|
set category = "Object"
|
|
set src in view(1)
|
|
|
|
try_toggle_open(usr)
|
|
|
|
/obj/item/modular_computer/laptop/mouse_drop_dragged(atom/over_object, mob/user, src_location, over_location, params)
|
|
if(over_object == user || over_object == src)
|
|
try_toggle_open(user)
|
|
return
|
|
if(istype(over_object, /atom/movable/screen/inventory/hand))
|
|
var/atom/movable/screen/inventory/hand/H = over_object
|
|
if(!isturf(loc))
|
|
return
|
|
user.put_in_hand(src, H.held_index)
|
|
|
|
/obj/item/modular_computer/laptop/proc/try_toggle_open(mob/living/user)
|
|
if(issilicon(user))
|
|
return
|
|
if(!isturf(loc) && !ismob(loc)) // No opening it in backpack.
|
|
return
|
|
if(!user.can_perform_action(src))
|
|
return
|
|
|
|
toggle_open(user)
|
|
|
|
|
|
/obj/item/modular_computer/laptop/click_alt(mob/user)
|
|
if(!screen_on)
|
|
return CLICK_ACTION_BLOCKING
|
|
try_toggle_open(user) // Close it.
|
|
return CLICK_ACTION_SUCCESS
|
|
|
|
/obj/item/modular_computer/laptop/attack_hand_secondary(mob/user, list/modifiers)
|
|
. = ..()
|
|
if(. == SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN)
|
|
return
|
|
|
|
attack_self(user)
|
|
return SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN
|
|
|
|
/obj/item/modular_computer/laptop/proc/toggle_open(mob/living/user=null)
|
|
if(screen_on)
|
|
to_chat(user, span_notice("You close \the [src]."))
|
|
slowdown -= slowdown_open
|
|
update_weight_class(initial(w_class))
|
|
drag_slowdown = initial(drag_slowdown)
|
|
else
|
|
to_chat(user, span_notice("You open \the [src]."))
|
|
slowdown += slowdown_open
|
|
update_weight_class(w_class_open)
|
|
drag_slowdown = slowdown_open
|
|
|
|
if(isliving(loc))
|
|
var/mob/living/localmob = loc
|
|
localmob.update_equipment_speed_mods()
|
|
localmob.update_pull_movespeed()
|
|
|
|
screen_on = !screen_on
|
|
update_appearance()
|
|
|
|
/obj/item/modular_computer/laptop/get_messenger_ending()
|
|
return "Sent from my UNIX Laptop"
|
|
|
|
// Laptop frame, starts empty and closed.
|
|
/obj/item/modular_computer/laptop/buildable
|
|
start_open = FALSE
|