cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-29 02:21:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
4db41ed99a227af2dfdce299b2073e25807110d2
Bubberstation/code/datums/elements
History
_0Steven 9314b73c2c Fixes critter crate elevation issues. (#91609) 
## About The Pull Request

Very simply put, we weren't actually unregistering the
`COMSIG_MOVABLE_MOVED` signal on detaching.
This was making it so that when you open a critter crate it doesn't
actually unregister the signal, meaning that it re-attaches a lot of its
effects to the turf the next time the crate moves. However, because it
wasn't actually *properly* attached anymore, breaking the crate wouldn't
unregister the turf.
So this was making it so that if you were to open a critter crate and
then move it immediately after, it would regain its ability to elevate
you as if it were closed, and this would linger even after it breaking.

This fixes that.
## Why It's Good For The Game

Fixes https://github.com/tgstation/tgstation/issues/91204.
## Changelog
🆑
fix: Critter crates no longer re-attain their ability to lift you
despite being open if you move one after opening it, and neither does
this lifting field stay after you destroy it.
/🆑
2025-06-14 10:57:37 -06:00
..
decals
Audits wash/cleaning signals + refactors wash() to ensure no needless mob updates occur (#91259)
2025-06-02 18:54:53 +00:00
food
Crafting refactor, implementing materials (#89465)
2025-06-01 16:37:43 -07:00
screentips
Sets prettier to run on the repo (#91379)
2025-05-29 21:23:59 -07:00
_element.dm
…
ai_control_examine.dm
Unregister noticeable AI controller when it unpossesses mob (#89201)
2025-01-26 14:32:42 +01:00
ai_flee_while_injured.dm
…
ai_held_item.dm
Reworks examine (a little) (#86506)
2024-09-10 22:47:58 +02:00
ai_retaliate.dm
Apply AI Controller Admin Verb (#89375)
2025-02-12 17:09:48 -07:00
ai_swap_combat_mode.dm
…
ai_target_damagesource.dm
…
animal_variety.dm
…
art.dm
Assorted changes to job assignment code and logging. Runtime free, guaranteed or your money back. Price: $£0. (#85947)
2024-09-13 13:58:35 +02:00
atmos_requirements.dm
…
atmos_sensitive.dm
…
attack_equip.dm
…
attack_zone_randomiser.dm
…
backblast.dm
…
bane.dm
Fixes Bane element runtime (#90889)
2025-04-30 19:23:55 +00:00
basic_allergenic_attack.dm
Adds Allergic reactions to a few things (Bee stings, Beer) (#87392)
2024-10-25 15:52:08 +02:00
basic_eating.dm
Refactor split_stack to two separate procs, fixes a hard delete in the process (#91306)
2025-05-25 03:14:53 +03:00
basic_health_examine.dm
…
basic_stamina_slowdown.dm
Most fleshy mobs are vulnerable to stamina and stuns (#90675)
2025-05-11 05:05:53 +10:00
beauty.dm
Refactoring aquariums into components (feat: portable fish tanks) (#87866)
2024-11-21 09:45:49 +13:00
bed_tucking.dm
Fixes bugs related to transferring items to turfs, splits doing that off from dropItemToGround(...) (#91326)
2025-06-01 00:59:56 +00:00
befriend_petting.dm
…
block_turf_fingerprints.dm
Heretic Influences use alt appearances (so ghosts can now see them (semi-transparent)) (#85932)
2024-09-05 15:00:01 +02:00
blocks_explosives.dm
…
blood_reagent.dm
[MDB IGNORE] Blood Refactor Chapter 2: Collector's Edition (#91054)
2025-05-31 19:38:07 -05:00
body_temp_sensitive.dm
…
bombable_turf.dm
…
bonus_damage.dm
…
bsa_blocker.dm
…
bugkiller_reagent.dm
Adds the bloodroach (#91383)
2025-06-04 14:57:11 -07:00
bump_click.dm
…
burn_when_item_ignition.dm
Fixes burning paper runtimes (#90499)
2025-04-09 21:33:16 +02:00
can_barricade.dm
…
can_shatter.dm
Fixes shatter element dropping stuff on blocked turfs (#88739)
2024-12-28 10:06:42 +00:00
caseless.dm
Adds a new syringe gun mode and improves foam darts. (#89510)
2025-03-01 22:52:19 +11:00
chain_lightning_attack.dm
Adds two fantasy affixes (#89257)
2025-02-08 15:35:11 -08:00
chemical_transfer.dm
…
chewable.dm
Fix chewable bubblegum not metabolizing due to microdose (#88102)
2024-11-23 11:33:33 +01:00
cleaning.dm
…
cliff_walker.dm
…
climbable.dm
Herculean/Atlas implants get a few additional BOULDER/Equipment related benefits. Boulders are more robust. Natural Athletics gains. (#87469)
2024-11-07 12:58:32 +00:00
connect_loc.dm
…
consumable_mob.dm
Fish (ya know, from fishing) is now edible (#86110)
2024-09-15 13:13:47 +02:00
content_barfer.dm
Space dragons can now catch and eat fish (plus shark form and rift fishing) (#86582)
2024-10-06 20:19:17 +02:00
corrupted_organ.dm
Resprites all eyes and gives cybernetic eyes unique sprites (#89841)
2025-03-06 21:17:01 -05:00
crackable.dm
…
crusher_loot.dm
new icebox ruin: outpost 31 + megafauna (technically???) (#88714)
2025-01-23 18:33:05 +01:00
cuffsnapping.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
cult_eyes.dm
Adds eye color overrides, converts cult/weed/silverscale eye effects to use them (#87782)
2024-11-10 11:54:46 +00:00
cult_halo.dm
…
curse_announcement.dm
…
cursed.dm
…
damage_threshold.dm
Reorganizes the sound folder (#86726)
2024-09-23 22:24:50 -07:00
dangerous_surgical_removal.dm
Adds more damages, flavors and podpeople to recovered crew (#87491)
2024-11-02 14:43:25 +01:00
death_drops.dm
Clown Abomination Rebalance! #Cytology2025 (#91000)
2025-05-17 16:36:04 +00:00
death_explosion.dm
…
death_gases.dm
…
delete_on_drop.dm
…
deliver_first.dm
Department orders credit reward and cooldown time now use a logarithmic scale (#88797)
2025-01-15 14:21:24 +01:00
dextrous.dm
Refactor: Moves throwing and giving items from /mob/living/carbon to /mob/living (#91049)
2025-05-22 09:02:28 +02:00
diggable.dm
…
digitalcamo.dm
Soft reworks changeling Darkness Adaptation (#89767)
2025-03-11 18:41:59 +01:00
disarm_attack.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
door_pryer.dm
Airlock prying from /datum/element/door_pryer does damage to the door like jaws of life prying (#89998)
2025-03-17 13:25:25 +01:00
drag_pickup.dm
…
dryable.dm
Crafting refactor, implementing materials (#89465)
2025-06-01 16:37:43 -07:00
earhealing.dm
The death or internal/external organ pathing (ft. fixed fox ears and recoloring bodypart overlays with dye sprays) (#87434)
2024-10-30 08:03:02 +01:00
easily_fragmented.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
easy_ignite.dm
[MDB IGNORE] Blood Refactor Chapter 2: Collector's Edition (#91054)
2025-05-31 19:38:07 -05:00
effect_trail.dm
…
ELEMENT_TEMPLATE.md
Sets prettier to run on the repo (#91379)
2025-05-29 21:23:59 -07:00
elevation.dm
Fixes critter crate elevation issues. (#91609)
2025-06-14 10:57:37 -06:00
empprotection.dm
…
envenomable_casing.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
eyestab.dm
The death or internal/external organ pathing (ft. fixed fox ears and recoloring bodypart overlays with dye sprays) (#87434)
2024-10-30 08:03:02 +01:00
falling_hazard.dm
Reorganizes the sound folder (#86726)
2024-09-23 22:24:50 -07:00
firestacker.dm
The fishening v3: Fishing lures. (#86007)
2024-09-06 19:50:28 -04:00
fish_safe_storage.dm
Fixes pre-filled fish stasis cases breaking fish inside of them (#89904)
2025-03-09 14:43:29 -04:00
floor_placeable.dm
Fixes bugs related to transferring items to turfs, splits doing that off from dropItemToGround(...) (#91326)
2025-06-01 00:59:56 +00:00
floorloving.dm
[NO GBP] Fixes hoverboard being able to be used in space. (#84533)
2024-07-07 15:18:08 -04:00
footstep_override.dm
…
footstep.dm
Make too low vols and no soundin scream for playsound instead of failing silently (#89746)
2025-03-02 12:41:32 +01:00
forced_gravity.dm
…
frozen.dm
The death or internal/external organ pathing (ft. fixed fox ears and recoloring bodypart overlays with dye sprays) (#87434)
2024-10-30 08:03:02 +01:00
gags_recolorable.dm
Removes a couple of duplicate gag map_icons + fixes the gags_recolorable component + most lootpanel gags previews (#91341)
2025-06-01 19:44:15 -07:00
give_turf_traits.dm
You can release fish after catching it (#86126)
2024-09-15 13:57:41 +00:00
glass_pacifist.dm
Fix various issues with names in string interpolation (#89246)
2025-01-29 17:46:03 +01:00
gravedigger.dm
…
hat_wearer.dm
The big fix for pixel_x and pixel_y use cases. (#90124)
2025-03-28 14:18:45 +00:00
haunted.dm
…
high_fiver.dm
Refactor: Moves throwing and giving items from /mob/living/carbon to /mob/living (#91049)
2025-05-22 09:02:28 +02:00
honkspam.dm
…
hostile_machine.dm
…
human_biter.dm
…
ignites_matches.dm
You can light a match on the heel of your boot (#88690)
2025-01-06 03:16:59 +01:00
immerse.dm
Adds "deep water" that you can drown in (#90587)
2025-04-21 08:06:06 -07:00
inverted_movement.dm
…
item_fov.dm
…
item_scaling.dm
…
kneecapping.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
kneejerk.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
knockback.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
leeching_walk.dm
Rust heretic healing now uses delta time (#88569)
2024-12-21 22:22:24 +01:00
lifesteal.dm
Refactored the on_hit_effect into an element. (#85034)
2024-07-23 13:50:55 -06:00
light_blocking.dm
Wallening Revert [MDB Ignore][IDB Ignore] (#86161)
2024-09-03 10:41:51 +02:00
light_eaten.dm
…
light_eater.dm
Space cola removes rust (#90452)
2025-04-08 12:07:21 -07:00
living_limb_initialiser.dm
…
loomable.dm
…
lube_walking.dm
…
mirage_border.dm
Converts most other usages of block() to x/y/z format (#89290)
2025-02-07 02:44:10 +01:00
mob_access.dm
…
mob_grabber.dm
…
mob_killed_tally.dm
…
move_force_on_death.dm
…
movement_turf_changer.dm
…
movetype_handler.dm
If you are upside down, you ignore elevation (#90147)
2025-03-23 17:46:43 +01:00
muffles_speech.dm
signers can sign past muzzles (#87488)
2024-10-27 15:05:55 +01:00
nav_computer_icon.dm
Nav computer icons (#88169)
2024-12-21 23:10:15 +01:00
nerfed_pulling.dm
…
no_crit_hitting.dm
Voidwalker Balancing, Fixes and Additions (#85045)
2024-07-20 21:41:44 +01:00
noisy_movement.dm
…
noticable_organ.dm
…
obj_regen.dm
…
on_hit_effect.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
only_pull_living.dm
Voidwalker Balancing, Fixes and Additions (#85045)
2024-07-20 21:41:44 +01:00
openspace_item_click_handler.dm
fix tile/rod/rcd multi-z hole repairs (#84255)
2024-06-25 00:34:17 -04:00
ore_collecting.dm
…
organ_set_bonus.dm
Cleans up duplicate calls in bodypart overlays, implements a texture priority system (#89783)
2025-03-11 13:28:34 -05:00
permanent_fire_overlay.dm
…
pet_bonus.dm
You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)
2025-04-23 20:18:26 +00:00
pet_collar.dm
Collars can no longer be used to null a pet's name (#86719)
2024-09-18 08:29:43 -04:00
pet_cult.dm
Pet Commands QOL . makes pet commands easier to use (#88495)
2024-12-22 03:05:30 +01:00
plant_backfire.dm
…
point_of_interest.dm
…
poster_tearer.dm
…
prevent_attacking_of_types.dm
…
proficient_miner.dm
Fixes green raptor corpses being able to mine rocks (#87558)
2024-10-30 17:15:30 +03:00
projectile_drop.dm
Guncode Agony 4: The Great Projectile Purge (#87740)
2024-11-23 04:02:35 -08:00
projectile_shield.dm
…
quality_food_ingredient.dm
Fishing expansion 2: one-year later boogaloo (#85252)
2024-08-20 06:46:11 +02:00
radiation_protected_clothing.dm
…
radioactive.dm
…
ranged_armour.dm
fixes parriable projectiles runtimes (#87899)
2024-11-14 11:22:48 +01:00
reagents_heated_on_fire.dm
[MDB Ignore] Damp Rag can now get dirty / Repaths damp rag (it's no longer a cup) (#90700)
2025-05-16 13:49:27 -07:00
reagents_item_heatable.dm
[MDB Ignore] Damp Rag can now get dirty / Repaths damp rag (it's no longer a cup) (#90700)
2025-05-16 13:49:27 -07:00
regal_rat_minion.dm
Regal Rat cleanup & minor changes (#91012)
2025-05-11 04:52:20 +03:00
relay_attackers.dm
Removes 'thrownby' var on items (#90877)
2025-04-30 10:29:29 +01:00
ridable.dm
fixes paraplegics appearing horizontal when riding animals (#87358)
2024-10-23 14:09:28 +02:00
rust.dm
Space cola removes rust (#90452)
2025-04-08 12:07:21 -07:00
selfknockback.dm
Guncode Agony 4: The Great Projectile Purge (#87740)
2024-11-23 04:02:35 -08:00
series.dm
…
shiny_bait.dm
material fishing rods and material fish. (#87108)
2024-11-03 11:20:39 -05:00
shuttle_construction_lattice.dm
Custom Shuttles Redux: Allows for the construction of custom shuttles. (#88493)
2025-02-23 17:18:43 +11:00
shuttle_construction_turf.dm
Multiple custom shuttle fixes (+one qol tweak) (#90898)
2025-05-07 13:06:27 +12:00
sideway_movement.dm
…
simple_flying.dm
Small hulk cleanup / nukes TRAIT_IGNOREDAMAGESLOWDOWN (#85003)
2024-07-17 01:14:08 +02:00
skill_reward.dm
…
skittish.dm
…
slapcrafting.dm
Cleans up crafting code, fixes multiple bugs (#90157)
2025-03-23 19:54:27 +01:00
slow_target_click_cd_attack.dm
Adds two fantasy affixes (#89257)
2025-02-08 15:35:11 -08:00
soft_landing.dm
…
spooky.dm
Improved dooting for spectral instruments. New fantasy suffix. (#88489)
2025-01-23 17:54:38 +00:00
squish_sound.dm
…
squish.dm
Rift Fishing (#88619)
2024-12-27 11:25:12 +00:00
strippable.dm
Fixes transparent_protection being used incorrectly almost everywhere (#90894)
2025-05-08 21:52:31 -05:00
structure_repair.dm
…
swabbable.dm
…
swimming_tile.dm
Makes deep water not quite so ultra lethal so you can actually go for a swim (#91135)
2025-05-20 22:11:58 +01:00
tenacious.dm
Tenacious element no longer prints a wear off message when added outside of soft crit and properly removes its effects when detached (#87901)
2024-11-14 19:11:00 +01:00
tiny_mob_hunter.dm
…
tool_flash.dm
…
tool_renaming.dm
Fixing several fish-related issues. (#87199)
2024-10-15 17:33:25 +00:00
toy_talk.dm
…
turf_transparency.dm
Allows you to look down ladders, both via verb/hotkey and, yknow, visually (#88876)
2025-01-08 13:54:08 -07:00
undertile.dm
Fixes weird pipe/vent/cable rendering under glass and catwalk floors (#91454)
2025-06-08 16:03:18 +00:00
unfriend_attacker.dm
…
update_icon_blocker.dm
…
update_icon_updates_onmob.dm
Fixes harddels, reduces unneccessary update body calls (#88300)
2024-12-04 01:34:57 +01:00
uplink_reimburse.dm
…
venomous.dm
Fix double injections (#87148)
2024-10-10 19:45:21 +00:00
volatile_gas_storage.dm
…
voucher_redeemer.dm
Fix mining vendors treating ALL items as mining vouchers (#90521)
2025-04-10 20:29:14 +02:00
waddling.dm
Fish infusion (#87030)
2024-10-09 02:03:50 +02:00
wall_engraver.dm
Replaces HAS_TRAIT_FROM with HAS_TRAIT in engraving checks (#86630)
2024-09-14 20:39:45 +00:00
wall_smasher.dm
…
wall_tearer.dm
Reorganizes the sound folder (#86726)
2024-09-23 22:24:50 -07:00
wall_walker.dm
Cult Vs. Heretic: 7 Months Later Edition (#82877)
2024-06-29 12:40:33 -05:00
watery_tile.dm
Adds "deep water" that you can drown in (#90587)
2025-04-21 08:06:06 -07:00
weapon_description.dm
Updates href uses for 516 (#88699)
2024-12-24 11:42:20 -08:00
wearable_client_colour.dm
Bravo Six, Going Dark: Refactors client colors to fix dupe issues and support filters (#89843)
2025-03-17 11:35:11 +00:00
weather_listener.dm
Weather DLC - Make it Rain Anything! (#89550)
2025-04-07 18:46:28 +02:00
web_walker.dm
…
wheel.dm
event based incapicated and able_to_run (#86031)
2024-09-04 10:02:49 -04:00
window_smash.dm
…