mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-01 02:12:49 +01:00
SmArtKar
6b83a91956
## About The Pull Request Reverts the storage initialization refactor and all subsequent related PRs. The original PR is below our standards both for code quality and testing, and is majorly flawed at its core. This has been discussed with other maintainers and headcoder(s?) over on discord. A lot of changes from the PR could be brought over later, but in its current state it should not have been merged. - Closes #90322 - Closes #90313 - Closes #90315 - Closes #90320 - Closes #90312 - Closes #90344 ## Why It's Good For The Game This PR causes a series of major issues which cannot be resolved without either completely rewriting a lot of the original PR, or bad code. Not matching our standards is grounds for not merging a PR, and the fact that a PR should not have been merged is a reason for a revert. ## Changelog 🆑 fix: Fixed a series of storage-related bugs caused by a refactor PR. /🆑
88 lines
3.2 KiB
Plaintext
88 lines
3.2 KiB
Plaintext
// This file contains all boxes used by the Engineering department and its purpose on the station. Also contains stuff we use when we wanna fix up stuff as well or helping us live when shit goes southwardly.
|
|
|
|
/obj/item/storage/box/metalfoam
|
|
name = "box of metal foam grenades"
|
|
desc = "To be used to rapidly seal hull breaches."
|
|
illustration = "grenade"
|
|
|
|
/obj/item/storage/box/metalfoam/PopulateContents()
|
|
for(var/i in 1 to 7)
|
|
new /obj/item/grenade/chem_grenade/metalfoam(src)
|
|
|
|
/obj/item/storage/box/smart_metal_foam
|
|
name = "box of smart metal foam grenades"
|
|
desc = "Used to rapidly seal hull breaches. This variety conforms to the walls of its area."
|
|
illustration = "grenade"
|
|
|
|
/obj/item/storage/box/smart_metal_foam/PopulateContents()
|
|
for(var/i in 1 to 7)
|
|
new/obj/item/grenade/chem_grenade/smart_metal_foam(src)
|
|
|
|
/obj/item/storage/box/debugtools
|
|
name = "box of debug tools"
|
|
icon_state = "syndiebox"
|
|
|
|
/obj/item/storage/box/debugtools/Initialize(mapload)
|
|
. = ..()
|
|
atom_storage.allow_big_nesting = TRUE
|
|
atom_storage.max_slots = 99
|
|
atom_storage.max_specific_storage = WEIGHT_CLASS_GIGANTIC
|
|
atom_storage.max_total_storage = 99
|
|
|
|
/obj/item/storage/box/debugtools/PopulateContents()
|
|
var/static/items_inside = list(
|
|
/obj/item/card/emag=1,
|
|
/obj/item/construction/rcd/combat/admin=1,
|
|
/obj/item/disk/tech_disk/debug=1,
|
|
/obj/item/flashlight/emp/debug=1,
|
|
/obj/item/geiger_counter=1,
|
|
/obj/item/healthanalyzer/advanced=1,
|
|
/obj/item/modular_computer/pda/heads/captain=1,
|
|
/obj/item/pipe_dispenser=1,
|
|
/obj/item/stack/spacecash/c1000=50,
|
|
/obj/item/storage/box/beakers/bluespace=1,
|
|
/obj/item/storage/box/beakers/variety=1,
|
|
/obj/item/storage/bag/sheetsnatcher/debug=1,
|
|
/obj/item/uplink/debug=1,
|
|
/obj/item/uplink/nuclear/debug=1,
|
|
/obj/item/clothing/ears/earmuffs/debug = 1,
|
|
)
|
|
generate_items_inside(items_inside,src)
|
|
|
|
/obj/item/storage/box/plastic
|
|
name = "plastic box"
|
|
desc = "It's a solid, plastic shell box."
|
|
icon_state = "plasticbox"
|
|
foldable_result = null
|
|
illustration = "writing"
|
|
custom_materials = list(/datum/material/plastic = HALF_SHEET_MATERIAL_AMOUNT) //You lose most if recycled.
|
|
|
|
/obj/item/storage/box/emergencytank
|
|
name = "emergency oxygen tank box"
|
|
desc = "A box of emergency oxygen tanks."
|
|
illustration = "emergencytank"
|
|
|
|
/obj/item/storage/box/emergencytank/PopulateContents()
|
|
..()
|
|
for(var/i in 1 to 7)
|
|
new /obj/item/tank/internals/emergency_oxygen(src) //in case anyone ever wants to do anything with spawning them, apart from crafting the box
|
|
|
|
/obj/item/storage/box/engitank
|
|
name = "extended-capacity emergency oxygen tank box"
|
|
desc = "A box of extended-capacity emergency oxygen tanks."
|
|
illustration = "extendedtank"
|
|
|
|
/obj/item/storage/box/engitank/PopulateContents()
|
|
..()
|
|
for(var/i in 1 to 7)
|
|
new /obj/item/tank/internals/emergency_oxygen/engi(src) //in case anyone ever wants to do anything with spawning them, apart from crafting the box
|
|
|
|
/obj/item/storage/box/stickers/chief_engineer
|
|
name = "CE approved sticker pack"
|
|
desc = "With one of these stickers, inform the crew that the contraption in the corridor is COMPLETELY SAFE!"
|
|
illustration = "label_ce"
|
|
|
|
/obj/item/storage/box/stickers/chief_engineer/PopulateContents()
|
|
for(var/i in 1 to 3)
|
|
new /obj/item/sticker/chief_engineer(src)
|