Files
Bubberstation/code/modules/mob
SkyratBot 33994b6fcc [MIRROR] Fixes dog fashion items not clearing up when removed from the dog & fixes armor vest dog fashion [MDB IGNORE] (#19642)
* Fixes dog fashion items not clearing up when removed from the dog & fixes armor vest dog fashion (#73743)

## About The Pull Request
Restores a `cut_overlays()` to dog's `regenerate_icons()` that was lost
back in #70799.
Also makes an armorvest back fashion for armor vests. When a dog fashion
datum doesn't have `obj_icon_state` declared, it defaults to the
assigned item's icon. Dog fashion's sprite sheet has the armor vest
sprite saved as _armor_. And the only vest that would actually show on a
dog would be an _alt_ armor vest. Apparently, the standard-issue armor
vest uses _armoralt_ icons. Go figure.
However, there are quite a few armor vest subtypes that don't look
anything like the base vest; this needs addressing by either banning
such vests from being used as dog fashion items, or making separate
sprites for them (to be fair, the current dog fashion armor vest needs
an update as well, it's quite old and doesn't correspond to the current
armor vest).
- [x] go around and remove dog fashion from armor vests that don't look
like the base vest

## Why It's Good For The Game
Closes #59224 (hats as items were not stuck, but their sprites were);
dog's sprites will correctly update upon placing/removing a fashion item
Most armor vests placed on a dog will actually show on the sprite

## Changelog
🆑
fix: undressing a hat/back item from a dog will correctly remove the
item's overlay
fix: most armor vests will actually show on a dog when placed on its
back
/🆑

* Fixes dog fashion items not clearing up when removed from the dog & fixes armor vest dog fashion

---------

Co-authored-by: Sealed101 <75863639+Sealed101@users.noreply.github.com>
2023-03-10 02:42:22 +00:00
..