mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-04 05:51:54 +00:00
88efc67db9
* Makes robotic talk use GetVoice for carbons, fixing voice changer issue (#81901) ## About The Pull Request I noticed that when using a chameleon set and agent ID to change my voice and then using the binary encryption key to talk over binary, it would actually show as "Real Name (as ID)" rather than "ID" as expected. Looking into the code, this seemed to be because robotic talk would use `name` rather than getting the voice of the speaker, which is set to the *visible name* of the speaker, leading to it using the visible name rather than their voice. This pr changes it to use `GetVoice` to have a result consistent with regular comms. ## Why It's Good For The Game When you use a chameleon mask with an agent ID it lets you mask your voice over comms even if your face isn't fully covered, it's your voice after all, but over robotic comms it cares about your visible name rather than your voice even though you're still talking into a headset. This pr makes it consistent with the behaviour of voice changing over regular comms. ## Changelog 🆑 fix: When a carbon talks over robotic it uses their voice instead of visible name. Meaning, voice changers work like they do over other comms regardless of face covering. /🆑 * Makes robotic talk use GetVoice for carbons, fixing voice changer issue --------- Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>