mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-09 16:05:07 +00:00
589cf0a904
## About The Pull Request This PR tackles our piss-poor item action handling. Currently in order to make an item only have actions when its equipped to a certain slot you need to override a proc, which I've changed by introducing an action_slots variable. I've also cleaned up a ton of action code, and most importantly moved a lot of Trigger effects on items to do_effect, which allows actions to not call ui_action_click or attack_self on an item without bypassing IsAvailible and comsigs that parent Trigger has. This resolves issues like jump boots being usable from your hands, HUDs being toggleable out of your pockets, etc. Also moved a few actions from relying on attack_self to individual handling on their side. This also stops welding masks/hardhats from showing their action while you hold them, this part of the change is just something I thought didn't make much sense - you can use their action by using them in-hand, and flickering on your action bar can be annoying when reshuffling your backpack. Closes #89653 ## Why It's Good For The Game Makes action handling significantly less ass, allows us to avoid code like this ```js /obj/item/clothing/mask/gas/sechailer/ui_action_click(mob/user, action) if(istype(action, /datum/action/item_action/halt)) halt() else adjust_visor(user) ```
162 lines
4.9 KiB
Plaintext
162 lines
4.9 KiB
Plaintext
/datum/action/item_action/toggle
|
|
|
|
/datum/action/item_action/toggle/New(Target)
|
|
..()
|
|
var/obj/item/item_target = target
|
|
name = "Toggle [item_target.name]"
|
|
|
|
/datum/action/item_action/toggle_light
|
|
name = "Toggle Light"
|
|
|
|
/datum/action/item_action/toggle_computer_light
|
|
name = "Toggle Flashlight"
|
|
|
|
/datum/action/item_action/toggle_hood
|
|
name = "Toggle Hood"
|
|
|
|
/datum/action/item_action/toggle_firemode
|
|
button_icon = 'modular_skyrat/master_files/icons/mob/actions/actions_items.dmi' //SKYRAT EDIT ADDITION
|
|
button_icon_state = "fireselect_no" //SKYRAT EDIT ADDITION
|
|
name = "Toggle Firemode"
|
|
|
|
/datum/action/item_action/toggle_gunlight
|
|
name = "Toggle Gunlight"
|
|
|
|
/datum/action/item_action/toggle_mode
|
|
name = "Toggle Mode"
|
|
|
|
/datum/action/item_action/toggle_barrier_spread
|
|
name = "Toggle Barrier Spread"
|
|
|
|
/datum/action/item_action/toggle_paddles
|
|
name = "Toggle Paddles"
|
|
|
|
/datum/action/item_action/toggle_mister
|
|
name = "Toggle Mister"
|
|
|
|
/datum/action/item_action/toggle_helmet_light
|
|
name = "Toggle Helmet Light"
|
|
|
|
/datum/action/item_action/toggle_welding_screen
|
|
name = "Toggle Welding Screen"
|
|
|
|
/datum/action/item_action/toggle_spacesuit
|
|
name = "Toggle Suit Thermal Regulator"
|
|
button_icon = 'icons/mob/actions/actions_spacesuit.dmi'
|
|
button_icon_state = "thermal_off"
|
|
|
|
/datum/action/item_action/toggle_spacesuit/apply_button_icon(atom/movable/screen/movable/action_button/button, force)
|
|
var/obj/item/clothing/suit/space/suit = target
|
|
if(istype(suit))
|
|
button_icon_state = "thermal_[suit.thermal_on ? "on" : "off"]"
|
|
|
|
return ..()
|
|
|
|
/datum/action/item_action/toggle_helmet_flashlight
|
|
name = "Toggle Helmet Flashlight"
|
|
|
|
/datum/action/item_action/toggle_helmet_mode
|
|
name = "Toggle Helmet Mode"
|
|
|
|
/datum/action/item_action/toggle_voice_box
|
|
name = "Toggle Voice Box"
|
|
|
|
/datum/action/item_action/toggle_human_head
|
|
name = "Toggle Human Head"
|
|
|
|
/datum/action/item_action/toggle_helmet
|
|
name = "Toggle Helmet"
|
|
|
|
/datum/action/item_action/toggle_seclight
|
|
name = "Toggle Seclight"
|
|
|
|
/datum/action/item_action/toggle_jetpack
|
|
name = "Toggle Jetpack"
|
|
|
|
/datum/action/item_action/jetpack_stabilization
|
|
name = "Toggle Jetpack Stabilization"
|
|
|
|
/datum/action/item_action/jetpack_stabilization/IsAvailable(feedback = FALSE)
|
|
var/obj/item/tank/jetpack/linked_jetpack = target
|
|
if(!istype(linked_jetpack) || !linked_jetpack.on)
|
|
return FALSE
|
|
return ..()
|
|
|
|
/datum/action/item_action/organ_action/toggle_hud
|
|
name = "Toggle Implant HUD"
|
|
desc = "Disables your HUD implant's visuals. You can still access examine information."
|
|
|
|
/datum/action/item_action/organ_action/toggle_hud/do_effect(trigger_flags)
|
|
var/obj/item/organ/cyberimp/eyes/hud/hud_implant = target
|
|
hud_implant.toggle_hud(owner)
|
|
return TRUE
|
|
|
|
/datum/action/item_action/wheelys
|
|
name = "Toggle Wheels"
|
|
desc = "Pops out or in your shoes' wheels."
|
|
button_icon = 'icons/mob/actions/actions_items.dmi'
|
|
button_icon_state = "wheelys"
|
|
|
|
/datum/action/item_action/kindle_kicks
|
|
name = "Activate Kindle Kicks"
|
|
desc = "Kick you feet together, activating the lights in your Kindle Kicks."
|
|
button_icon = 'icons/mob/actions/actions_items.dmi'
|
|
button_icon_state = "kindleKicks"
|
|
|
|
/datum/action/item_action/storage_gather_mode
|
|
name = "Switch gathering mode"
|
|
desc = "Switches the gathering mode of a storage object."
|
|
background_icon = 'icons/mob/actions/actions_items.dmi'
|
|
background_icon_state = "storage_gather_switch"
|
|
overlay_icon_state = "bg_tech_border"
|
|
|
|
/datum/action/item_action/flip
|
|
name = "Flip"
|
|
|
|
/datum/action/item_action/call_link
|
|
name = "Call MODlink"
|
|
|
|
/datum/action/item_action/toggle_wearable_hud
|
|
name = "Toggle Wearable HUD"
|
|
desc = "Toggles your wearable HUD. You can still access examine information while it's off."
|
|
|
|
/datum/action/item_action/toggle_wearable_hud/do_effect(trigger_flags)
|
|
var/obj/item/clothing/glasses/hud/hud_display = target
|
|
hud_display.toggle_hud_display(owner)
|
|
return TRUE
|
|
|
|
/datum/action/item_action/toggle_nv
|
|
name = "Toggle Night Vision"
|
|
var/stored_cutoffs
|
|
var/stored_colour
|
|
|
|
/datum/action/item_action/toggle_nv/New(obj/item/clothing/glasses/target)
|
|
. = ..()
|
|
target.AddElement(/datum/element/update_icon_updates_onmob)
|
|
|
|
/datum/action/item_action/toggle_nv/do_effect(trigger_flags)
|
|
if(!istype(target, /obj/item/clothing/glasses))
|
|
return ..()
|
|
var/obj/item/clothing/glasses/goggles = target
|
|
var/mob/holder = goggles.loc
|
|
if(!istype(holder) || holder.get_slot_by_item(goggles) != ITEM_SLOT_EYES)
|
|
holder = null
|
|
if(stored_cutoffs)
|
|
goggles.color_cutoffs = stored_cutoffs
|
|
goggles.flash_protect = FLASH_PROTECTION_SENSITIVE
|
|
stored_cutoffs = null
|
|
if(stored_colour)
|
|
goggles.change_glass_color(stored_colour)
|
|
playsound(goggles, 'sound/items/night_vision_on.ogg', 30, TRUE, -3)
|
|
else
|
|
stored_cutoffs = goggles.color_cutoffs
|
|
stored_colour = goggles.glass_colour_type
|
|
goggles.color_cutoffs = list()
|
|
goggles.flash_protect = FLASH_PROTECTION_NONE
|
|
if(stored_colour)
|
|
goggles.change_glass_color(null)
|
|
playsound(goggles, 'sound/machines/click.ogg', 30, TRUE, -3)
|
|
holder?.update_sight()
|
|
goggles.update_appearance()
|
|
return TRUE
|