mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-07 15:32:47 +00:00
## About The Pull Request
A year ago in #73601 (b7da743e7d), we made
it such that we wouldn't apply the `/datum/status_effect/fire_handler`
to any basic mob that wasn't a "flammable" mob. However, guess what? The
way we handle "wet stacks" is handled by a subtype,
`/datum/status_effect/fire_handler/wet_stacks`. This means that any mob
that wasn't flammable wouldn't also get wet, meaning that they would
literally _never_ get the `slimed` status effect off them (since that is
reliant on wet stacks).
In order to rectify this, let's actually account for the case in the
code to ensure that mobs that should get wet do get wet (I made it an
opt-out flag because I can't think of a single mob that can't get wet
and didn't want to balloon the diff trying to think of every mob that
should be able to get wet, etc.), and now it's all fixed hunky-dory.
## Why It's Good For The Game
Fixes #81888
Basic mobs should be able to get wet. It's an oversight with how the
wet_stack handler is tacked onto the backend of the fire_handler
latticework- ideally these two would be two separate systems (or it
would at least not be named `fire_handler` so people don't make this
confusion in the future without realizing that it handles more than
just... `fire`) but I don't have time to do a full cleansing and
refactor of this code.
## Changelog
🆑
fix: All basic mobs are able to get wet. This means, among other things,
that you can clear the "slimed" status effect off your holoparasite or
dog or whatever.
/🆑