mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-22 23:15:13 +00:00
b70d871224
## About The Pull Request `/datum/antagonist/nukeop/leader/move_to_spawnpoint()` overrides `/datum/antagonist/nukeop/move_to_spawnpoint()`, which is responsible for calling `SSmapping.lazy_load_template(LAZY_TEMPLATE_KEY_NUKIEBASE)` Nuke op leaders also get created first thing, so they always got sent to arrivals `move_to_spawnpoint` now is not overridden by anything, location is now obtained though `get_spawnpoint` But this doesn't solve the entire issue! Seemed like there was a race condition in that, on nukie team creation, it looked for the nuke to generate the nuke code. But it created the team before creating the nuke (and template). So it runtimed and broke, no nukies. So I had to go deeper. Rulesets have this list, `ruleset_lazy_templates`, that none of the midround rulesets used. CC @ZephyrTFA on this, but it seemed like it caused a few issues related to lazyloading by missing them? I added the keys to abductor and nukies. and also ninja even though it'll probably never be used I also also made the kidnapping objective for traitors pre-emptively load the holding facility on objective *taken*, rather than waiting for the exact moment which the victim is kidnapped. (Should) Fix #72248 ## Why It's Good For The Game LATE FOR WORK ## Changelog 🆑 Melbert fix: Nuke Ops Leaders midround don't spawn on Arrivals Shuttle late for work fix: (Maybe) fixes some additional issues related to midround nukie / abductor spawns /🆑 --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>