mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-22 23:15:13 +00:00
* Standardizes attack chain signal returns and fixes a tk bug (#54475) The attack chain is a bit of a mess, and the introduction of signals hasn't helped in simplifying it. In order to take a step into untangling this, I re-ordered the attack signals to no longer be by source type and instead to be grouped more modularly, as they are all members of the attack chain and function similarly. They all share the trait of potentially ending the attack chain via a return, but had several different names for it. I joined it into one. Additionally, fixed a tk bug reported by @ Timberpoes by adding a signal return check at the base of /mob/proc/RangedAttack Lastly, removed the async call of /datum/mutation/human/telekinesis/proc/on_ranged_attack, which was added as a lazy patch to appease the linter complaining about a sleep on a signal handler (namely in /obj/singularity/attack_tk). Fixed the problem using timers. Also cleaned some code here and there. * Standardizes attack chain signal returns and fixes a tk bug Co-authored-by: Rohesie <rohesie@gmail.com>
136 lines
6.2 KiB
Plaintext
136 lines
6.2 KiB
Plaintext
/datum/component/butchering
|
|
var/speed = 80 //time in deciseconds taken to butcher something
|
|
var/effectiveness = 100 //percentage effectiveness; numbers above 100 yield extra drops
|
|
var/bonus_modifier = 0 //percentage increase to bonus item chance
|
|
var/butcher_sound = 'sound/effects/butcher.ogg' //sound played when butchering
|
|
var/butchering_enabled = TRUE
|
|
var/can_be_blunt = FALSE
|
|
|
|
/datum/component/butchering/Initialize(_speed, _effectiveness, _bonus_modifier, _butcher_sound, disabled, _can_be_blunt)
|
|
if(_speed)
|
|
speed = _speed
|
|
if(_effectiveness)
|
|
effectiveness = _effectiveness
|
|
if(_bonus_modifier)
|
|
bonus_modifier = _bonus_modifier
|
|
if(_butcher_sound)
|
|
butcher_sound = _butcher_sound
|
|
if(disabled)
|
|
butchering_enabled = FALSE
|
|
if(_can_be_blunt)
|
|
can_be_blunt = _can_be_blunt
|
|
if(isitem(parent))
|
|
RegisterSignal(parent, COMSIG_ITEM_ATTACK, .proc/onItemAttack)
|
|
|
|
/datum/component/butchering/proc/onItemAttack(obj/item/source, mob/living/M, mob/living/user)
|
|
SIGNAL_HANDLER
|
|
|
|
if(user.a_intent != INTENT_HARM)
|
|
return
|
|
if(M.stat == DEAD && (M.butcher_results || M.guaranteed_butcher_results)) //can we butcher it?
|
|
if(butchering_enabled && (can_be_blunt || source.get_sharpness()))
|
|
INVOKE_ASYNC(src, .proc/startButcher, source, M, user)
|
|
return COMPONENT_CANCEL_ATTACK_CHAIN
|
|
|
|
if(ishuman(M) && source.force && source.get_sharpness())
|
|
var/mob/living/carbon/human/H = M
|
|
if((user.pulling == H && user.grab_state >= GRAB_AGGRESSIVE) && user.zone_selected == BODY_ZONE_HEAD) // Only aggressive grabbed can be sliced.
|
|
if(H.has_status_effect(/datum/status_effect/neck_slice))
|
|
user.show_message("<span class='warning'>[H]'s neck has already been already cut, you can't make the bleeding any worse!</span>", MSG_VISUAL, \
|
|
"<span class='warning'>Their neck has already been already cut, you can't make the bleeding any worse!</span>")
|
|
return COMPONENT_CANCEL_ATTACK_CHAIN
|
|
INVOKE_ASYNC(src, .proc/startNeckSlice, source, H, user)
|
|
return COMPONENT_CANCEL_ATTACK_CHAIN
|
|
|
|
/datum/component/butchering/proc/startButcher(obj/item/source, mob/living/M, mob/living/user)
|
|
to_chat(user, "<span class='notice'>You begin to butcher [M]...</span>")
|
|
playsound(M.loc, butcher_sound, 50, TRUE, -1)
|
|
if(do_mob(user, M, speed) && M.Adjacent(source))
|
|
Butcher(user, M)
|
|
|
|
/datum/component/butchering/proc/startNeckSlice(obj/item/source, mob/living/carbon/human/H, mob/living/user)
|
|
if(INTERACTING_WITH(user, H))
|
|
to_chat(user, "<span class='warning'>You're already interacting with [H]!</span>")
|
|
return
|
|
|
|
user.visible_message("<span class='danger'>[user] is slitting [H]'s throat!</span>", \
|
|
"<span class='danger'>You start slicing [H]'s throat!</span>", \
|
|
"<span class='hear'>You hear a cutting noise!</span>", ignored_mobs = H)
|
|
H.show_message("<span class='userdanger'>Your throat is being slit by [user]!</span>", MSG_VISUAL, \
|
|
"<span class = 'userdanger'>Something is cutting into your neck!</span>", NONE)
|
|
log_combat(user, H, "starts slicing the throat of")
|
|
|
|
playsound(H.loc, butcher_sound, 50, TRUE, -1)
|
|
if(do_mob(user, H, clamp(500 / source.force, 30, 100)) && H.Adjacent(source))
|
|
if(H.has_status_effect(/datum/status_effect/neck_slice))
|
|
user.show_message("<span class='warning'>[H]'s neck has already been already cut, you can't make the bleeding any worse!</span>", MSG_VISUAL, \
|
|
"<span class='warning'>Their neck has already been already cut, you can't make the bleeding any worse!</span>")
|
|
return
|
|
|
|
H.visible_message("<span class='danger'>[user] slits [H]'s throat!</span>", \
|
|
"<span class='userdanger'>[user] slits your throat...</span>")
|
|
log_combat(user, H, "finishes slicing the throat of")
|
|
H.apply_damage(source.force, BRUTE, BODY_ZONE_HEAD, wound_bonus=CANT_WOUND) // easy tiger, we'll get to that in a sec
|
|
var/obj/item/bodypart/slit_throat = H.get_bodypart(BODY_ZONE_HEAD)
|
|
if(slit_throat)
|
|
var/datum/wound/slash/critical/screaming_through_a_slit_throat = new
|
|
screaming_through_a_slit_throat.apply_wound(slit_throat)
|
|
H.apply_status_effect(/datum/status_effect/neck_slice)
|
|
|
|
/datum/component/butchering/proc/Butcher(mob/living/butcher, mob/living/meat)
|
|
var/turf/T = meat.drop_location()
|
|
var/final_effectiveness = effectiveness - meat.butcher_difficulty
|
|
var/bonus_chance = max(0, (final_effectiveness - 100) + bonus_modifier) //so 125 total effectiveness = 25% extra chance
|
|
for(var/V in meat.butcher_results)
|
|
var/obj/bones = V
|
|
var/amount = meat.butcher_results[bones]
|
|
for(var/_i in 1 to amount)
|
|
if(!prob(final_effectiveness))
|
|
if(butcher)
|
|
to_chat(butcher, "<span class='warning'>You fail to harvest some of the [initial(bones.name)] from [meat].</span>")
|
|
else if(prob(bonus_chance))
|
|
if(butcher)
|
|
to_chat(butcher, "<span class='info'>You harvest some extra [initial(bones.name)] from [meat]!</span>")
|
|
for(var/i in 1 to 2)
|
|
new bones (T)
|
|
else
|
|
new bones (T)
|
|
meat.butcher_results.Remove(bones) //in case you want to, say, have it drop its results on gib
|
|
for(var/V in meat.guaranteed_butcher_results)
|
|
var/obj/sinew = V
|
|
var/amount = meat.guaranteed_butcher_results[sinew]
|
|
for(var/i in 1 to amount)
|
|
new sinew (T)
|
|
meat.guaranteed_butcher_results.Remove(sinew)
|
|
if(butcher)
|
|
butcher.visible_message("<span class='notice'>[butcher] butchers [meat].</span>", \
|
|
"<span class='notice'>You butcher [meat].</span>")
|
|
ButcherEffects(meat)
|
|
meat.harvest(butcher)
|
|
meat.gib(FALSE, FALSE, TRUE)
|
|
|
|
/datum/component/butchering/proc/ButcherEffects(mob/living/meat) //extra effects called on butchering, override this via subtypes
|
|
return
|
|
|
|
///Special snowflake component only used for the recycler.
|
|
/datum/component/butchering/recycler
|
|
|
|
/datum/component/butchering/recycler/Initialize(_speed, _effectiveness, _bonus_modifier, _butcher_sound, disabled, _can_be_blunt)
|
|
if(!istype(parent, /obj/machinery/recycler)) //EWWW
|
|
return COMPONENT_INCOMPATIBLE
|
|
. = ..()
|
|
if(. == COMPONENT_INCOMPATIBLE)
|
|
return
|
|
RegisterSignal(parent, COMSIG_MOVABLE_CROSSED, .proc/onCrossed)
|
|
|
|
/datum/component/butchering/recycler/proc/onCrossed(datum/source, mob/living/L)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!istype(L))
|
|
return
|
|
var/obj/machinery/recycler/eater = parent
|
|
if(eater.safety_mode || (eater.machine_stat & (BROKEN|NOPOWER))) //I'm so sorry.
|
|
return
|
|
if(L.stat == DEAD && (L.butcher_results || L.guaranteed_butcher_results))
|
|
Butcher(parent, L)
|