mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-06 06:52:39 +00:00
e41cc39888
## About The Pull Request Fixes #73276 This is a followup PR from my series of biotype updates. Changed oxyloss to default to ignoring biotype requirements. Fixes a bug in lung code that was preventing mobs from suffocating under certain conditions. ~~Now biotype requirements for oxyloss are respected only when `forced` is set to `FALSE`, which I have done for all applicable reagents. This is more of a temporary fix for until the damage system gets a refactor to better accommodate biotypes. @Time-Green and @LemonInTheDark would know what I mean, we were just talking about this. There is a problem with `MOB_ORGANIC` being the deafult and this is the ugly workaround.~~ Edit: I felt that oxyloss (which should be renamed to something else at this point) should have its own flag to check what type of respiration the mob's lungs can do. Because you can have organic mobs that breathe different gases. It gets messy when you try to use the same flag for everything. So I refactored oxyloss to use a new lung flag, `respiration_type`, which is automatically set based on the `safe_min_oxygen`, `safe_min_plasma` etc variables within the lung code. This will allow for individual lung types to dynamically determine whether they can take oxyloss from reagents, or any other sources that pass the `respiration_type` in the `adjustOxyLoss` proc. ## Why It's Good For The Game Plasmamen can't breathe without plasma anymore. Humans can't breathe without oxygen anymore. Etc. Adds better handling for dealing with the 'oxyloss' damage type, allowing it to be applied based on the type of gas being breathed by the specific lung. The argumentless default is to apply it regardless of respiration_type e.g. it behaves exactly as it did before. ## Changelog 🆑 fix: fixes oxyloss not being applied when there is a partial pressure of 0 (no more being able to breathe in space) code: fixes any lingering damage-application issues related to non MOB_ORGANIC biotypes refactor: refactored lungs to have a respiration_type flag which is then used by adjustOxyloss/setOxyloss to determine whether to take 'oxygen' damage. /🆑
123 lines
3.9 KiB
Plaintext
123 lines
3.9 KiB
Plaintext
//DO NOT ADD MORE TO THIS FILE.
|
|
//Use vv_do_topic() for datums!
|
|
/client/proc/view_var_Topic(href, href_list, hsrc)
|
|
if( (usr.client != src) || !src.holder || !holder.CheckAdminHref(href, href_list))
|
|
return
|
|
var/target = GET_VV_TARGET
|
|
vv_do_basic(target, href_list, href)
|
|
if(isdatum(target))
|
|
var/datum/D = target
|
|
D.vv_do_topic(href_list)
|
|
else if(islist(target))
|
|
vv_do_list(target, href_list)
|
|
if(href_list["Vars"])
|
|
debug_variables(locate(href_list["Vars"]))
|
|
|
|
//Stuff below aren't in dropdowns/etc.
|
|
|
|
if(check_rights(R_VAREDIT))
|
|
|
|
//~CARN: for renaming mobs (updates their name, real_name, mind.name, their ID/PDA and datacore records).
|
|
|
|
if(href_list["rename"])
|
|
if(!check_rights(NONE))
|
|
return
|
|
|
|
var/mob/M = locate(href_list["rename"]) in GLOB.mob_list
|
|
if(!istype(M))
|
|
to_chat(usr, "This can only be used on instances of type /mob", confidential = TRUE)
|
|
return
|
|
|
|
var/new_name = stripped_input(usr,"What would you like to name this mob?","Input a name",M.real_name,MAX_NAME_LEN)
|
|
|
|
// If the new name is something that would be restricted by IC chat filters,
|
|
// give the admin a warning but allow them to do it anyway if they want.
|
|
if(is_ic_filtered(new_name) || is_soft_ic_filtered(new_name) && tgui_alert(usr, "Your selected name contains words restricted by IC chat filters. Confirm this new name?", "IC Chat Filter Conflict", list("Confirm", "Cancel")) == "Cancel")
|
|
return
|
|
|
|
if( !new_name || !M )
|
|
return
|
|
|
|
message_admins("Admin [key_name_admin(usr)] renamed [key_name_admin(M)] to [new_name].")
|
|
M.fully_replace_character_name(M.real_name,new_name)
|
|
vv_update_display(M, "name", new_name)
|
|
vv_update_display(M, "real_name", M.real_name || "No real name")
|
|
|
|
else if(href_list["rotatedatum"])
|
|
if(!check_rights(NONE))
|
|
return
|
|
|
|
var/atom/A = locate(href_list["rotatedatum"])
|
|
if(!istype(A))
|
|
to_chat(usr, "This can only be done to instances of type /atom", confidential = TRUE)
|
|
return
|
|
|
|
switch(href_list["rotatedir"])
|
|
if("right")
|
|
A.setDir(turn(A.dir, -45))
|
|
if("left")
|
|
A.setDir(turn(A.dir, 45))
|
|
vv_update_display(A, "dir", dir2text(A.dir))
|
|
|
|
|
|
else if(href_list["adjustDamage"] && href_list["mobToDamage"])
|
|
if(!check_rights(NONE))
|
|
return
|
|
|
|
var/mob/living/L = locate(href_list["mobToDamage"]) in GLOB.mob_list
|
|
if(!istype(L))
|
|
return
|
|
|
|
var/Text = href_list["adjustDamage"]
|
|
|
|
var/amount = input("Deal how much damage to mob? (Negative values here heal)","Adjust [Text]loss",0) as num|null
|
|
|
|
if (isnull(amount))
|
|
return
|
|
|
|
if(!L)
|
|
to_chat(usr, "Mob doesn't exist anymore", confidential = TRUE)
|
|
return
|
|
|
|
var/newamt
|
|
switch(Text)
|
|
if("brute")
|
|
L.adjustBruteLoss(amount, forced = TRUE)
|
|
newamt = L.getBruteLoss()
|
|
if("fire")
|
|
L.adjustFireLoss(amount, forced = TRUE)
|
|
newamt = L.getFireLoss()
|
|
if("toxin")
|
|
L.adjustToxLoss(amount, forced = TRUE)
|
|
newamt = L.getToxLoss()
|
|
if("oxygen")
|
|
L.adjustOxyLoss(amount, forced = TRUE)
|
|
newamt = L.getOxyLoss()
|
|
if("brain")
|
|
L.adjustOrganLoss(ORGAN_SLOT_BRAIN, amount)
|
|
newamt = L.getOrganLoss(ORGAN_SLOT_BRAIN)
|
|
if("clone")
|
|
L.adjustCloneLoss(amount, forced = TRUE)
|
|
newamt = L.getCloneLoss()
|
|
if("stamina")
|
|
L.adjustStaminaLoss(amount, forced = TRUE)
|
|
newamt = L.getStaminaLoss()
|
|
else
|
|
to_chat(usr, "You caused an error. DEBUG: Text:[Text] Mob:[L]", confidential = TRUE)
|
|
return
|
|
|
|
if(amount != 0)
|
|
var/log_msg = "[key_name(usr)] dealt [amount] amount of [Text] damage to [key_name(L)]"
|
|
message_admins("[key_name(usr)] dealt [amount] amount of [Text] damage to [ADMIN_LOOKUPFLW(L)]")
|
|
log_admin(log_msg)
|
|
admin_ticket_log(L, "<font color='blue'>[log_msg]</font>")
|
|
vv_update_display(L, Text, "[newamt]")
|
|
|
|
|
|
//Finally, refresh if something modified the list.
|
|
if(href_list["datumrefresh"])
|
|
var/datum/DAT = locate(href_list["datumrefresh"])
|
|
if(isdatum(DAT) || istype(DAT, /client) || islist(DAT))
|
|
debug_variables(DAT)
|
|
|