mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-26 01:22:03 +00:00
7dca77fcbd
* Check for compliant JSON before receiving payload (#69023) About The Pull Request This was denied in the past for perf reasons, but I want to test how much this actually reduces perf. rustg_json_is_valid checks for two things. It checks that the data isn't too nested. This could easily be removed if it causes perf problems, since it's an extra O(n) check of its own. It was for a BYOND exploit that is now fixed. It checks for JSON compliancy. It is backed by serde_json, which does not allow NaN, whereas BYOND is incompliant. This does not lady_beetle ribbon 𝒻𝒾𝓍 ribbon lady_beetle #69017, because that is doing an extra text2num for no reason. If it didn't (like it shouldn't), then this would fix it. Will be test merged on Manuel but not Sybil--CC @ LemonInTheDark help me on figuring out the perf cost of this. If it's noticable then we can test with removing the depth check. * Check for compliant JSON before receiving payload Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>