mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-27 01:51:50 +00:00
e65a48e91f
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761) Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks. Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work. This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping. To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway. Requested by @optimumtact. Changelog cl admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again. /cl * Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
35 lines
1014 B
Plaintext
35 lines
1014 B
Plaintext
/datum/element/forced_gravity
|
|
element_flags = ELEMENT_BESPOKE
|
|
id_arg_index = 2
|
|
var/gravity
|
|
var/ignore_space
|
|
|
|
/datum/element/forced_gravity/Attach(datum/target, gravity=1, ignore_space=FALSE)
|
|
. = ..()
|
|
if(!isatom(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
|
|
src.gravity = gravity
|
|
src.ignore_space = ignore_space
|
|
|
|
RegisterSignal(target, COMSIG_ATOM_HAS_GRAVITY, .proc/gravity_check)
|
|
if(isturf(target))
|
|
RegisterSignal(target, COMSIG_TURF_HAS_GRAVITY, .proc/turf_gravity_check)
|
|
|
|
/datum/element/forced_gravity/Detach(datum/source, force)
|
|
. = ..()
|
|
var/static/list/signals_b_gone = list(COMSIG_ATOM_HAS_GRAVITY, COMSIG_TURF_HAS_GRAVITY)
|
|
UnregisterSignal(source, signals_b_gone)
|
|
|
|
/datum/element/forced_gravity/proc/gravity_check(datum/source, turf/location, list/gravs)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!ignore_space && isspaceturf(location))
|
|
return
|
|
gravs += gravity
|
|
|
|
/datum/element/forced_gravity/proc/turf_gravity_check(datum/source, atom/checker, list/gravs)
|
|
SIGNAL_HANDLER
|
|
|
|
return gravity_check(null, source, gravs)
|