mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-15 11:39:18 +00:00
fa8785514b
* Galactic Market Hot Fixes (#78836)
## About The Pull Request
1. Fixes #78732
The "Order Via Cargo Budget" button no longer appears in the UI if you
don't have cargo access in your ID
2. Fixes #78730
Orders made privately & orders made via cargo budget now come in
different crates
So cargo ordered crates no longer require QM cargo budget card and can
be opened by anyone as intended wheras privatly ordered crates come with
your regular secure access facility. This occurred when assigning the
bank account to the order
e41730f6e4/code/modules/cargo/materials_market.dm (L201)
This param is only meant to check if you want an access secured
crate(which you should get for private orders) or an normal crate for
cargo orders. If null it will send you the regular cargo crate
3. Fixes #78731
Orders made privately vs orders made with cargo budget are now separate
and not bundled together
So if you first make an order privately & them switch to cargo budget or
vice versa it will still separate your orders. This way you get what you
ordered privately in a separate crate and cargo gets their crate
separately for it's purposes
4. New Qol now money will be deducted from cargo budget/your account
only after the order is confirmed in the cargo request console & after
shuttle is called and arrives with your packages This way you drain the
budget only after your orders were successfully delivered and not before
hand itself. We don't have to worry about making orders that exceed our
budget cause cargo already has bound checking code for that so let it do
its thing. Here for example cargo only had 500 credits but i ordered way
too much so it gracefully rejected it
6. This also addresses
https://github.com/tgstation/tgstation/pull/78729#pullrequestreview-1654922282
by making the for loop treat the items in the list as paths by using the
`as anything in` clause in the for loop.
## Changelog
🆑
fix: You cannot order with cargo budget if you don't have cargo access
in the Galactic Market
fix: Private & Cargo orders no longer get mixed together in the same
crate if you order them interchangeably so no more embezzlement in the
Galactic Market
fix: Orders made with cargo budget come in a regular cargo crate thus
allowing you to open them without QM cargo budget card in the Galactic
Market
qol: Orders made in the Galactic Market will deduct money from your
account/cargo budget only after the order has been confirmed in the
cargo request console & after the shuttle arrives with your order. This
way you drain the budget only after your orders were successfully
delivered and not before hand itself
/🆑
* Galactic Market Hot Fixes
---------
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>