mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-30 03:22:41 +00:00
be18901411
* [ready] unit tests all worn icons (#72370) Fixes #71692 🆑 ShizCalev code: Added a unit test for ALL worn icons. fix: Fixed a bunch of broken worn icons! /🆑 * [ready] unit tests all worn icons * Should have fixed most of the failures now * Here, hopefully that should fix what was left * Okay maybe it just hadn't been fixed yet * I can be a bit dumb sometimes * Okay, now it's going to work, I promise * I'm so tired of this Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com> Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com> Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
118 lines
5.7 KiB
Plaintext
118 lines
5.7 KiB
Plaintext
/// Makes sure suit slot items aren't using CS:S fallbacks.
|
|
/datum/unit_test/worn_icons
|
|
var/static/list/possible_icon_states = list()
|
|
/// additional_icon_location is for downstream modularity support for finding missing sprites in additonal DMI file locations.
|
|
/// Make sure this location is also present in tools/deploy.sh
|
|
/// If you need additional paths ontop of this second one, you can add another generate_possible_icon_states_list("your/folder/path/") below the if(additional_icon_location) block in Run(), and make sure to add that path to tools/deploy.sh as well.
|
|
var/additional_icon_location = null
|
|
|
|
/datum/unit_test/worn_icons/proc/generate_possible_icon_states_list(directory_path)
|
|
if(!directory_path)
|
|
directory_path = "icons/mob/clothing/"
|
|
for(var/file_path in flist(directory_path))
|
|
if(findtext(file_path, ".dmi"))
|
|
for(var/sprite_icon in icon_states("[directory_path][file_path]", 1)) //2nd arg = 1 enables 64x64+ icon support, otherwise you'll end up with "sword0_1" instead of "sword"
|
|
possible_icon_states[sprite_icon] += list("[directory_path][file_path]")
|
|
else
|
|
possible_icon_states += generate_possible_icon_states_list("[directory_path][file_path]")
|
|
|
|
/datum/unit_test/worn_icons/Run()
|
|
generate_possible_icon_states_list()
|
|
if(additional_icon_location)
|
|
generate_possible_icon_states_list(additional_icon_location)
|
|
|
|
var/list/already_warned_icons = list()
|
|
|
|
for(var/obj/item/item_path as anything in (subtypesof(/obj/item) - typesof(/obj/item/mod)))
|
|
var/cached_slot_flags = initial(item_path.slot_flags)
|
|
if(!cached_slot_flags || (cached_slot_flags & ITEM_SLOT_LPOCKET) || (cached_slot_flags & ITEM_SLOT_RPOCKET) || initial(item_path.item_flags) & ABSTRACT)
|
|
continue
|
|
|
|
|
|
if(initial(item_path.greyscale_colors) && initial(item_path.greyscale_config_worn)) //GAGS has its own unit test.
|
|
continue
|
|
|
|
var/worn_icon = initial(item_path.worn_icon) //override icon file. where our sprite is contained if set. (ie modularity stuff)
|
|
var/worn_icon_state = initial(item_path.worn_icon_state) //overrides icon_state.
|
|
var/icon_state = worn_icon_state || initial(item_path.icon_state) //icon_state. what sprite name we are looking for.
|
|
|
|
|
|
if(isnull(icon_state))
|
|
continue //no sprite for the item.
|
|
if(icon_state in already_warned_icons)
|
|
continue
|
|
|
|
var/match_message
|
|
if(icon_state in possible_icon_states)
|
|
for(var/file_place in possible_icon_states[icon_state])
|
|
match_message += (match_message ? " & '[file_place]'" : " - Matching sprite found in: '[file_place]'")
|
|
|
|
if(worn_icon) //easiest to check since we override everything. this automatically includes downstream support.
|
|
if(!(icon_state in icon_states(worn_icon, 1)))
|
|
TEST_FAIL("[item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in worn_icon override file, '[worn_icon]'[match_message]")
|
|
continue
|
|
|
|
var/icon_file //checks against all the default icon locations if one isn't defined.
|
|
var/fail_reasons
|
|
var/spacer
|
|
if(cached_slot_flags & ITEM_SLOT_BACK)
|
|
icon_file = 'icons/mob/clothing/back.dmi'
|
|
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_ID)
|
|
icon_file = 'icons/mob/clothing/id.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_GLOVES)
|
|
icon_file = 'icons/mob/clothing/hands.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_EYES)
|
|
icon_file = 'icons/mob/clothing/eyes.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_EARS)
|
|
icon_file = 'icons/mob/clothing/ears.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_NECK)
|
|
icon_file = 'icons/mob/clothing/neck.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_MASK)
|
|
icon_file = 'icons/mob/clothing/mask.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(cached_slot_flags & ITEM_SLOT_BELT)
|
|
icon_file = 'icons/mob/clothing/belt.dmi'
|
|
if(!(icon_state in icon_states(icon_file, 1)))
|
|
already_warned_icons += icon_state
|
|
fail_reasons += "[spacer][item_path] using invalid [worn_icon_state ? "worn_icon_state" : "icon_state"], \"[icon_state]\" in '[icon_file]'[match_message]"
|
|
spacer = "\n\t"
|
|
|
|
if(fail_reasons)
|
|
TEST_FAIL(fail_reasons)
|
|
|