mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-25 00:22:39 +00:00
e90a9b4b68
## About The Pull Request Ok so like, side map right? It makes things higher up in the world render above things lower down in the world. Most of the time this is what we want, but it is NOT what we want for floors. Floors are allowed to be larger then 32x32, and if they are we want them to render based off JUST their layer. If we don't allow this grass turfs and others get cut off on their bottom edge, which looks WEIRD. In order to make this happen, we can add TOPDOWN_LAYER to every layer on the floor plane and disable sidemap. I've added documentation for this to VISUALS.md, and have also implemented unit test errors to prevent mixing TOPDOWN layers with non topdown planes (or vis versa). This new test adds ~1 second to tests, which is I think a perfectly scrumpulent number. EDIT: I nerd sniped myself and implemented sidemap layering and lighting for cameras (also larger then 32x32 icon support for getflat) The lighting isn't perfect, we don't handle things displaying in the void all that well (I am convinced getflat blending is broken but I have no debugger so I can't fix it properly), but it'll do. This came up cause I had to fix another layering issue in cameras and thought I might as well go all in.  ## Why It's Good For The Game Old:  New:  ## Changelog 🆑 fix: Grass turfs will render properly now. Reworked how floors render, please report any bugs! fix: Cameras now properly capture lighting fix: The layering seen in photos should better match the actual game /🆑
53 lines
2.4 KiB
Plaintext
53 lines
2.4 KiB
Plaintext
/// These tests perform no behavior of their own, and have their tests offloaded onto other procs.
|
|
/// This is useful in cases like in build_appearance_list where we want to know if any fail,
|
|
/// but is not useful to right a test for.
|
|
/// This file exists so that you can change any of these to TEST_FOCUS and only check for that test.
|
|
/// For example, change /datum/unit_test/focus_only/invalid_overlays to TEST_FOCUS(/datum/unit_test/focus_only/invalid_overlays),
|
|
/// and you will only test the check for invalid overlays in appearance building.
|
|
/datum/unit_test/focus_only
|
|
|
|
/// Checks that every created emissive has a valid icon_state
|
|
/datum/unit_test/focus_only/invalid_emissives
|
|
|
|
/// Checks that every overlay passed into build_appearance_list exists in the icon
|
|
/datum/unit_test/focus_only/invalid_overlays
|
|
|
|
/// Checks that every icon sent to the research_designs spritesheet is valid
|
|
/datum/unit_test/focus_only/invalid_research_designs
|
|
|
|
/// Checks that every icon sent to vending machines is valid
|
|
/datum/unit_test/focus_only/invalid_vending_machine_icon_states
|
|
|
|
/// Checks that space does not initialize multiple times
|
|
/datum/unit_test/focus_only/multiple_space_initialization
|
|
|
|
/// Checks that smoothing_groups and canSmoothWith are properly sorted in /atom/Initialize
|
|
/datum/unit_test/focus_only/sorted_smoothing_groups
|
|
|
|
/// Checks that floor tiles are properly mapped to broken/burnt
|
|
/datum/unit_test/focus_only/valid_turf_states
|
|
|
|
/// Checks that nightvision eyes have a full set of color lists
|
|
/datum/unit_test/focus_only/nightvision_color_cutoffs
|
|
|
|
/// Checks that no light shares a tile/pixel offsets with another
|
|
/datum/unit_test/focus_only/stacked_lights
|
|
|
|
/// Checks for bad icon / icon state setups in cooking crafting menu
|
|
/datum/unit_test/focus_only/bad_cooking_crafting_icons
|
|
|
|
/// Ensures openspace never spawns on the bottom of a z stack
|
|
/datum/unit_test/focus_only/openspace_clear
|
|
|
|
/// Checks to ensure that variables expected to exist in a job datum (for config reasons) actually exist
|
|
/datum/unit_test/focus_only/missing_job_datum_variables
|
|
|
|
/// Checks that the contents of the fish_counts list are also present in fish_table
|
|
/datum/unit_test/focus_only/fish_sources_tables
|
|
|
|
/// Checks that maploaded mobs with either the `atmos_requirements` or `body_temp_sensitive`
|
|
/datum/unit_test/focus_only/atmos_and_temp_requirements
|
|
|
|
/// Ensures only whitelisted planes can have TOPDOWN_LAYERing, and vis versa
|
|
/datum/unit_test/focus_only/topdown_filtering
|