Files
Bubberstation/code/modules/admin/fun_balloon.dm
BurgerLUA e87045b377 Tweaks some instances of get_safe_turf so things like the nuclear disk doesn't accidentally teleport to the Icebox Syndicate Base (#83012)
Yes, I know preventing the nuke disk teleporting to the icebox syndicate
base (or possibly the wendigo arena) is removing soul. Please don't kill
me :(

## About The Pull Request

Adds some missing variables to instances of get_safe_turf() so they will
only teleport to the given z-level.
Replaces some instances of get_safe_turf() with
get_safe_random_station_turf().

## Why It's Good For The Game

First, the differences between get_safe_turf() and
get_safe_random_station_turf():

### get_safe_turf()
- gets a random safe turf on a z-level (usually any of the staiton
z-levels), not accounting for the /area/
- should be used if you don't care if it spawns on the station or not,
or if you need to specifically teleport to a z-level
- not very expensive performance wise

###  get_safe_random_station_turf()
- gets a random safe turf that will always be a station area, ignoring
z-level.
- should be used if you NEED the turf to be on a station's area
- slightly more expensive performance wise than get_safe_turf, but still
very cheap

Some code was using get_safe_turf() when it should've been using
get_safe_random_station_turf(), and some code that should be using
get_safe_turf() were incorrectly using the zlevels arg instead of zlevel
arg (Yes, there is a difference), or didn't include it at all.

All the changes were made to my best judgement. If you're curious about
a change, please ask and I will explain why I did it.

## Changelog

🆑 BurgerBB
fix: Tweaks some instances of get_safe_turf so things like the nuclear
disk doesn't accidentally teleport to the Icebox Syndicate Base
/🆑

---------

Co-authored-by: Jacquerel <hnevard@gmail.com>
2024-06-14 21:57:33 +01:00

174 lines
4.9 KiB
Plaintext

/obj/effect/fun_balloon
name = "fun balloon"
desc = "This is going to be a laugh riot."
icon = 'icons/obj/toys/balloons.dmi'
icon_state = "syndballoon"
anchored = TRUE
var/popped = FALSE
var/pop_sound_effect = 'sound/items/party_horn.ogg'
/obj/effect/fun_balloon/Initialize(mapload)
. = ..()
SSobj.processing |= src
/obj/effect/fun_balloon/Destroy()
SSobj.processing -= src
. = ..()
/obj/effect/fun_balloon/process()
if(!popped && check() && !QDELETED(src))
popped = TRUE
effect()
pop()
/obj/effect/fun_balloon/proc/check()
return FALSE
/obj/effect/fun_balloon/proc/effect()
return
/obj/effect/fun_balloon/proc/pop()
visible_message(span_notice("[src] pops!"))
playsound(get_turf(src), pop_sound_effect, 50, TRUE, -1)
qdel(src)
// ----------- Sentience Balloon
/obj/effect/fun_balloon/sentience
name = "sentience fun balloon"
desc = "When this pops, things are gonna get more aware around here."
var/group_name = "a bunch of giant spiders"
var/effect_range = 3
var/antag_type = null
var/make_antag = FALSE
/obj/effect/fun_balloon/sentience/ui_interact(mob/user, datum/tgui/ui)
ui = SStgui.try_update_ui(user, src, ui)
if(!ui)
ui = new(user, src, "SentienceFunBalloon", name)
ui.open()
/obj/effect/fun_balloon/sentience/ui_data(mob/user)
var/list/data = list()
data["group_name"] = group_name
data["range"] = effect_range
data["antag"] = make_antag
return data
/obj/effect/fun_balloon/sentience/ui_state(mob/user)
return GLOB.admin_state
/obj/effect/fun_balloon/sentience/ui_status(mob/user, datum/ui_state/state)
if(popped)
return UI_CLOSE
if(isAdminObserver(user)) // ignore proximity if we're an admin
return UI_INTERACTIVE
return ..()
/obj/effect/fun_balloon/sentience/ui_act(action, list/params)
. = ..()
if(.)
return
switch(action)
if("group_name")
group_name = params["updated_name"]
if("effect_range")
effect_range = params["updated_range"]
if("select_antag")
var/list/paths = subtypesof(/datum/antagonist)
antag_type = input(usr,"Select antag", "Antagonist selection") as null|anything in sort_list(paths)
make_antag = TRUE
if("pop")
if(!popped)
popped = TRUE
effect()
pop()
return TRUE
/obj/effect/fun_balloon/sentience/effect()
var/list/bodies = list()
for(var/mob/living/possessable in range(effect_range, get_turf(src)))
if (!possessable.ckey && possessable.stat == CONSCIOUS) // Only assign ghosts to living, non-occupied mobs!
bodies += possessable
var/list/candidates = SSpolling.poll_ghosts_for_targets(
question = "Would you like to be [span_notice(group_name)]?",
role = ROLE_SENTIENCE,
check_jobban = ROLE_SENTIENCE,
poll_time = 10 SECONDS,
checked_targets = bodies,
ignore_category = POLL_IGNORE_SHUTTLE_DENIZENS,
alert_pic = src,
role_name_text = "sentience fun balloon",
)
while(LAZYLEN(candidates) && LAZYLEN(bodies))
var/mob/dead/observer/C = pick_n_take(candidates)
var/mob/living/body = pick_n_take(bodies)
message_admins("[key_name_admin(C)] has taken control of ([key_name_admin(body)])")
body.ghostize(FALSE)
body.key = C.key
if (make_antag)
body.mind.add_antag_datum(antag_type)
continue
new /obj/effect/temp_visual/gravpush(get_turf(body))
// ----------- Emergency Shuttle Balloon
/obj/effect/fun_balloon/sentience/emergency_shuttle
name = "shuttle sentience fun balloon"
var/trigger_time = 60
/obj/effect/fun_balloon/sentience/emergency_shuttle/check()
. = FALSE
if(SSshuttle.emergency && (SSshuttle.emergency.timeLeft() <= trigger_time) && (SSshuttle.emergency.mode == SHUTTLE_CALL))
. = TRUE
// ----------- Scatter Balloon
/obj/effect/fun_balloon/scatter
name = "scatter fun balloon"
desc = "When this pops, you're not going to be around here anymore."
var/effect_range = 5
/obj/effect/fun_balloon/scatter/effect()
for(var/mob/living/M in range(effect_range, get_turf(src)))
var/turf/T = find_safe_turf(zlevel = src.z)
new /obj/effect/temp_visual/gravpush(get_turf(M))
M.forceMove(T)
to_chat(M, span_notice("Pop!"), confidential = TRUE)
// ----------- Station Crash
// Can't think of anywhere better to put it right now
/obj/effect/station_crash
name = "station crash"
desc = "With no survivors!"
icon = 'icons/obj/toys/balloons.dmi'
icon_state = "syndballoon"
anchored = TRUE
var/min_crash_strength = 3
var/max_crash_strength = 15
/obj/effect/station_crash/Initialize(mapload)
..()
shuttle_crash()
return INITIALIZE_HINT_QDEL
/obj/effect/station_crash/proc/shuttle_crash()
var/crash_strength = rand(min_crash_strength,max_crash_strength)
for (var/S in SSshuttle.stationary_docking_ports)
var/obj/docking_port/stationary/SM = S
if (SM.shuttle_id == "emergency_home")
var/new_dir = REVERSE_DIR(SM.dir)
SM.forceMove(get_ranged_target_turf(SM, new_dir, crash_strength))
break
/obj/effect/station_crash/devastating
name = "devastating station crash"
desc = "Absolute Destruction. Will crash the shuttle far into the station."
min_crash_strength = 15
max_crash_strength = 25