mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-23 07:26:05 +00:00
a77ac3e4f1
## About The Pull Request Adds a new component, called wall_mounted, which applies on the wallframe objects on construction, as well as a number of wall frame objects and structures to cover mapped in, roundstart objects of the like. I might have forgotten a few, but this covers the vast majority that players will run into in a given round. This will cover wall destruction, turf explosion, the whole nine yards, and call that object/structure/machine's deconstruct proc. We have some special handling for intercoms as well since they're apparently items. So most basic case is this: You have a wall. that wall holds a sign. If you examine the wall, it tells you that the wall is currently supporting the **Example Sign**. It tells you that if the wall is damaged or destroyed, the sign will **fall off the wall.** So, if you were to welder, bomb, or hulk your way through that wall, it would call the deconstruct() proc on that sign, and fall off the wall, leaving an item sign at the foot of the wall. ## To-Do - [x] Stop breaking all wallmounts when operating shuttles (Signal conflict with COMSIG_TURF_CHANGED 😔) - [x] Confirm that the ~~deconstruct~~ designated proc of each wallmount falling is sane for the intended object - [x] Clean up the contents of the wall_mounted component to reduce copy-paste on object init. - [x] Add it to more stuff that may just not have a directional helper? - [x] ~~Change how APC construction is handled to make it easier!~~ - [x] ~~Don't accidently nerf malf AI into the ground I guess~~ ## Why It's Good For The Game Closes #22283. Helps close more of #47526. Closes #54983. Closes https://github.com/wall-nerds/wallening/issues/90. All of these objects are "wall mounts". It stands to reason that they're mounted to the walls they appear to be attached to. This attempts to rectify them by giving them a turf link to the turf they're mounted to, and then upon changes to that turf, dropping or breaking that object. It'll need a little more polish to get to 100%, since I can see a few more issues to iron out first, but I'm dropping this here for now to get some feedback and put some fire under me to get this completed. ## Changelog 🆑 add: Wall mounted objects (Things like APCs, Air Alarms, Light switches, Signs, Posters, Newscasters, you name it) will now fall to the ground and break or deconstruct when their attaching wall is changed or broken. /🆑
178 lines
4.6 KiB
Plaintext
178 lines
4.6 KiB
Plaintext
#define MAX_NOTICES 8
|
|
|
|
/obj/structure/noticeboard
|
|
name = "notice board"
|
|
desc = "A board for pinning important notices upon. It is made of the finest Spanish cork."
|
|
icon = 'icons/obj/wallmounts.dmi'
|
|
icon_state = "noticeboard"
|
|
density = FALSE
|
|
anchored = TRUE
|
|
max_integrity = 150
|
|
/// Current number of a pinned notices
|
|
var/notices = 0
|
|
|
|
MAPPING_DIRECTIONAL_HELPERS(/obj/structure/noticeboard, 32)
|
|
|
|
/obj/structure/noticeboard/Initialize(mapload)
|
|
. = ..()
|
|
|
|
if(!mapload)
|
|
return
|
|
|
|
for(var/obj/item/I in loc)
|
|
if(notices >= MAX_NOTICES)
|
|
break
|
|
if(istype(I, /obj/item/paper))
|
|
I.forceMove(src)
|
|
notices++
|
|
update_appearance(UPDATE_ICON)
|
|
find_and_hang_on_wall()
|
|
|
|
//attaching papers!!
|
|
/obj/structure/noticeboard/attackby(obj/item/O, mob/user, params)
|
|
if(istype(O, /obj/item/paper) || istype(O, /obj/item/photo))
|
|
if(!allowed(user))
|
|
to_chat(user, span_warning("You are not authorized to add notices!"))
|
|
return
|
|
if(notices < MAX_NOTICES)
|
|
if(!user.transferItemToLoc(O, src))
|
|
return
|
|
notices++
|
|
update_appearance(UPDATE_ICON)
|
|
to_chat(user, span_notice("You pin the [O] to the noticeboard."))
|
|
else
|
|
to_chat(user, span_warning("The notice board is full!"))
|
|
else
|
|
return ..()
|
|
|
|
/obj/structure/noticeboard/ui_state(mob/user)
|
|
return GLOB.physical_state
|
|
|
|
/obj/structure/noticeboard/ui_interact(mob/user, datum/tgui/ui)
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "NoticeBoard", name)
|
|
ui.open()
|
|
|
|
/obj/structure/noticeboard/ui_data(mob/user)
|
|
var/list/data = list()
|
|
data["allowed"] = allowed(user)
|
|
data["items"] = list()
|
|
for(var/obj/item/content in contents)
|
|
var/list/content_data = list(
|
|
name = content.name,
|
|
ref = REF(content)
|
|
)
|
|
data["items"] += list(content_data)
|
|
return data
|
|
|
|
/obj/structure/noticeboard/ui_act(action, params)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
|
|
var/obj/item/item = locate(params["ref"]) in contents
|
|
if(!istype(item) || item.loc != src)
|
|
return
|
|
|
|
var/mob/user = usr
|
|
|
|
switch(action)
|
|
if("examine")
|
|
if(istype(item, /obj/item/paper))
|
|
item.ui_interact(user)
|
|
else
|
|
user.examinate(item)
|
|
return TRUE
|
|
if("remove")
|
|
if(!allowed(user))
|
|
return
|
|
remove_item(item, user)
|
|
return TRUE
|
|
|
|
/obj/structure/noticeboard/update_overlays()
|
|
. = ..()
|
|
if(notices)
|
|
. += "notices_[notices]"
|
|
|
|
/**
|
|
* Removes an item from the notice board
|
|
*
|
|
* Arguments:
|
|
* * item - The item that is to be removed
|
|
* * user - The mob that is trying to get the item removed, if there is one
|
|
*/
|
|
/obj/structure/noticeboard/proc/remove_item(obj/item/item, mob/user)
|
|
item.forceMove(drop_location())
|
|
if(user)
|
|
user.put_in_hands(item)
|
|
balloon_alert(user, "removed from board")
|
|
notices--
|
|
update_appearance(UPDATE_ICON)
|
|
|
|
/obj/structure/noticeboard/deconstruct(disassembled = TRUE)
|
|
if(!(flags_1 & NODECONSTRUCT_1))
|
|
if(!disassembled)
|
|
new /obj/item/stack/sheet/mineral/wood(loc)
|
|
else
|
|
new /obj/item/wallframe/noticeboard(loc)
|
|
for(var/obj/item/content in contents)
|
|
remove_item(content)
|
|
qdel(src)
|
|
|
|
/obj/item/wallframe/noticeboard
|
|
name = "notice board"
|
|
desc = "Right now it's more of a clipboard. Attach to a wall to use."
|
|
icon = 'icons/obj/wallmounts.dmi'
|
|
icon_state = "noticeboard"
|
|
custom_materials = list(
|
|
/datum/material/wood = SHEET_MATERIAL_AMOUNT,
|
|
)
|
|
resistance_flags = FLAMMABLE
|
|
result_path = /obj/structure/noticeboard
|
|
pixel_shift = 32
|
|
|
|
// Notice boards for the heads of staff (plus the qm)
|
|
|
|
/obj/structure/noticeboard/captain
|
|
name = "Captain's Notice Board"
|
|
desc = "Important notices from the Captain."
|
|
req_access = list(ACCESS_CAPTAIN)
|
|
|
|
/obj/structure/noticeboard/hop
|
|
name = "Head of Personnel's Notice Board"
|
|
desc = "Important notices from the Head of Personnel."
|
|
req_access = list(ACCESS_HOP)
|
|
|
|
/obj/structure/noticeboard/ce
|
|
name = "Chief Engineer's Notice Board"
|
|
desc = "Important notices from the Chief Engineer."
|
|
req_access = list(ACCESS_CE)
|
|
|
|
/obj/structure/noticeboard/hos
|
|
name = "Head of Security's Notice Board"
|
|
desc = "Important notices from the Head of Security."
|
|
req_access = list(ACCESS_HOS)
|
|
|
|
/obj/structure/noticeboard/cmo
|
|
name = "Chief Medical Officer's Notice Board"
|
|
desc = "Important notices from the Chief Medical Officer."
|
|
req_access = list(ACCESS_CMO)
|
|
|
|
/obj/structure/noticeboard/rd
|
|
name = "Research Director's Notice Board"
|
|
desc = "Important notices from the Research Director."
|
|
req_access = list(ACCESS_RD)
|
|
|
|
/obj/structure/noticeboard/qm
|
|
name = "Quartermaster's Notice Board"
|
|
desc = "Important notices from the Quartermaster."
|
|
req_access = list(ACCESS_QM)
|
|
|
|
/obj/structure/noticeboard/staff
|
|
name = "Staff Notice Board"
|
|
desc = "Important notices from the heads of staff."
|
|
req_access = list(ACCESS_COMMAND)
|
|
|
|
#undef MAX_NOTICES
|