cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-19 02:59:17 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
888e6ff64a53c3c7d1e3dfb11ed4f009a9eb3f41
Bubberstation/code/controllers/subsystem
T
History
WaterpigandGitHub 888e6ff64a Fixes polling returning a list full of nulls when not enough candidates are available (#86012) 
## About The Pull Request

I was trying to fix an unrelated bug with abductors on a downstream that
I'm not even sure exists on here and found another unrelated bug.

Turns out polling always returns the list of a requested size, except it
fills in the empty spots with nulls.

![image](https://github.com/user-attachments/assets/9a9c8f0f-32eb-4106-98a6-2c61960960ca)

This makes this check completely broken, and runtimes abductors trying
to spawn with null clients, making the one lone abductor spawn naked on
the shuttle.

![image](https://github.com/user-attachments/assets/67707002-5898-4b40-99fd-24f8c8b9a167)

There might be an issue open for this but I was unable to find one

## Why It's Good For The Game

Uuuuh bugfix good.

See it working here

![image](https://github.com/user-attachments/assets/3be58814-ce4e-4b0f-a8d5-ec1efffb46df)

![image](https://github.com/user-attachments/assets/bd5ed3d0-60cf-44ac-88bd-822f1a2ea7e7)

## Changelog

🆑
fix: SSPolling no longer fills in the candidate list with empty entries
to guarantee it returns a list size of amount_to_pick
/🆑
2024-08-25 03:53:01 -04:00
..
dynamic
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
movement
Corrects 200+ instances of "it's" where it should've been "its" instead (#85169)
2024-07-21 13:41:37 -06:00
persistence
Add messages (paper, photos, cash) in bottles. (#85703)
2024-08-24 01:31:38 -04:00
processing
Fishing expansion 2: one-year later boogaloo (#85252)
2024-08-20 06:46:11 +02:00
achievements.dm
…
addiction.dm
…
admin_verbs.dm
…
ai_controllers.dm
idle basic mobs can plan again (#85348)
2024-08-14 13:50:44 +02:00
ai_idle_controllers.dm
idle basic mobs can plan again (#85348)
2024-08-14 13:50:44 +02:00
air.dm
Spelling and Grammar Fixes (#85992)
2024-08-21 17:07:02 +12:00
ambience.dm
Spelling and Grammar Fixes (#85992)
2024-08-21 17:07:02 +12:00
area_contents.dm
…
asset_loading.dm
…
assets.dm
…
atoms.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
augury.dm
…
ban_cache.dm
…
bitrunning.dm
Bitrunning: Combat domain [READY] (#84196)
2024-07-02 23:03:12 -04:00
blackbox.dm
Curator LIVE Journalism (#86046)
2024-08-25 00:21:12 +02:00
chat.dm
…
circuit_component.dm
…
dbcore.dm
…
dcs.dm
Code cleanup: Sorting (#83017)
2024-05-04 23:33:52 -04:00
discord.dm
Corrects 200+ instances of "it's" where it should've been "its" instead (#85169)
2024-07-21 13:41:37 -06:00
disease.dm
…
early_assets.dm
…
economy.dm
…
events.dm
Spelling and Grammar Fixes (#85992)
2024-08-21 17:07:02 +12:00
explosions.dm
…
fluids.dm
…
garbage.dm
Replaces Auxlua with the byondapi-based Dreamluau (#84810)
2024-07-28 18:45:49 +00:00
icon_smooth.dm
…
id_access.dm
Shrunk arrow from pointing at things. Command roles unaffected thanks to id trims (also new skillchip). (#85892)
2024-08-18 16:08:08 -04:00
init_profiler.dm
…
input.dm
Spelling and Grammar Fixes (#85992)
2024-08-21 17:07:02 +12:00
ipintel.dm
Moves as many db related date/time operations to the db side to avoid byond bugs with dates and times. (#83193)
2024-05-14 15:48:38 -06:00
job.dm
Revert "Assorted changes to job assignment code and logging." (#85929)
2024-08-17 15:26:08 -07:00
lag_switch.dm
…
library.dm
…
lighting.dm
localizes create_all_lighting_objects (#85135)
2024-07-29 15:42:14 +01:00
lua.dm
Replaces Auxlua with the byondapi-based Dreamluau (#84810)
2024-07-28 18:45:49 +00:00
machines.dm
APC and SSmachines hotfixes [NO GBP] (#85043)
2024-07-19 01:18:38 +02:00
mapping.dm
Block atmos processing on ReservedTurfs\™️ (#84873)
2024-08-15 18:45:59 +02:00
market.dm
refactor pod spawn from code copypaste to use podspawn instead. Add convenient way to spawn multiple items of same type in pod (#85151)
2024-07-29 15:45:34 +01:00
materials.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
minor_mapping.dm
Smuggler satchel spawning is blacklisted in the "near station" area (#85248)
2024-07-29 15:53:36 +01:00
mobs.dm
…
modular_computers.dm
Spelling and Grammar Fixes (#85992)
2024-08-21 17:07:02 +12:00
moods.dm
…
mouse_entered.dm
…
nightshift.dm
…
npcpool.dm
…
ore_generation.dm
…
overlays.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
pai.dm
Fixes pAIs permanently blocking requests (#82900)
2024-04-27 18:44:28 -06:00
parallax.dm
The Voidwalker | New Midround Antagonist (#84674)
2024-07-14 18:57:44 +00:00
pathfinder.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
persistent_paintings.dm
Positive moodlets when examining high-value paintings, plus tgui nitpicks (#84646)
2024-07-15 14:13:24 +01:00
ping.dm
…
points_of_interest.dm
…
polling.dm
Fixes polling returning a list full of nulls when not enough candidates are available (#86012)
2024-08-25 03:53:01 -04:00
profiler.dm
Adds a config to change the interval profiler information gets saved (#83849)
2024-06-13 23:54:47 -06:00
queuelinks.dm
…
radiation.dm
Fixes Pathfinder module AGAIN, General JPS Tweak (#84348)
2024-06-27 00:01:36 -04:00
radio.dm
…
radioactive_nebula.dm
…
research.dm
Fixes Research queue runtimes (#85020)
2024-07-17 20:11:04 +02:00
restaurant.dm
…
runechat.dm
…
security_level.dm
…
server_maint.dm
…
shuttle.dm
Reworks silicon/ai access checking & fixes some ui_act's (#84964)
2024-08-19 10:43:45 +00:00
skills.dm
…
sound_loops.dm
…
sounds.dm
…
spatial_gridmap.dm
Corrects 200+ instances of "it's" where it should've been "its" instead (#85169)
2024-07-21 13:41:37 -06:00
speech_controller.dm
…
sprite_accessories.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
statpanel.dm
Remove data systems in favor of global datums (#82943)
2024-04-29 22:47:36 -07:00
stickyban.dm
…
stock_market.dm
Corrects 200+ instances of "it's" where it should've been "its" instead (#85169)
2024-07-21 13:41:37 -06:00
sun.dm
…
tcgsetup.dm
…
tgui.dm
…
throwing.dm
Wallening [IDB IGNORE] [MDB IGNORE] (#85491)
2024-08-14 09:07:45 +00:00
ticker.dm
Revert "Assorted changes to job assignment code and logging." (#85929)
2024-08-17 15:26:08 -07:00
time_track.dm
Spelling and Grammar Fixes (#85992)
2024-08-21 17:07:02 +12:00
timer.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
title.dm
Fixes a runtime caused by incorrect arguments (#85895)
2024-08-17 16:44:04 +02:00
traitor.dm
…
transport.dm
Corrects 200+ instances of "it's" where it should've been "its" instead (#85169)
2024-07-21 13:41:37 -06:00
tts.dm
…
tutorials.dm
…
verb_manager.dm
Spelling and Grammar Fixes (#86022)
2024-08-23 21:49:46 +02:00
vis_overlays.dm
Wallening [IDB IGNORE] [MDB IGNORE] (#85491)
2024-08-14 09:07:45 +00:00
vote.dm
Reworks silicon/ai access checking & fixes some ui_act's (#84964)
2024-08-19 10:43:45 +00:00
wardrobe.dm
…
weather.dm
…
wiremod_composite.dm
…