mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-21 03:59:59 +01:00
JacquerelandGitHub
72c8a02f6c
## About The Pull Request This PR replaces a bunch of instances of mobs being able to smash walls by clicking them once to being able to tear walls by standing next to them for a few seconds while an animation occurs. Wall tearing is a three-part animation and can be cancelled and resumed at any point from the most recently completed step so it isn't _exactly_ a single two second interaction, and is resultingly harder to interrupt.  Some mobs still destroy walls in a single click, such as Flesh Worms and Star Gazers. Really whether I replaced this or not was largely down to vibes. It also deletes the `tear_walls` element because it was the same as `wall_tearer` but without the fun visuals. ## Why It's Good For The Game Deleting walls instantly with a single click is pretty obnoxious. This method slows it down a _little_ bit but also looks visually cooler and gives people on the _other_ side of the wall a warning that something is about to bust through kool-aid man style. ## Changelog 🆑 balance: Gorillas, Seedlings, Gold Grubs, Mooks, Constructs, Ascended Knock Heretics, Fugu and mobs subject to a Fugu Gland now rip up walls in a slightly slower but more cinematic way. /🆑
85 lines
3.5 KiB
Plaintext
85 lines
3.5 KiB
Plaintext
/// Returned if we can rip up this target
|
|
#define WALL_TEAR_ALLOWED TRUE
|
|
/// Returned if we can't rip up this target
|
|
#define WALL_TEAR_INVALID FALSE
|
|
/// Returned if we can't rip up the target but still don't want to attack it
|
|
#define WALL_TEAR_FAIL_CANCEL_CHAIN -1
|
|
|
|
/**
|
|
* Allows attached mobs to destroy walls over time, a little less unreasonable than the instant wall deletion of wall_smasher
|
|
*/
|
|
/datum/element/wall_tearer
|
|
element_flags = ELEMENT_BESPOKE
|
|
argument_hash_start_idx = 2
|
|
/// Whether we can break reinforced walls
|
|
var/allow_reinforced
|
|
/// How long it takes for us to destroy a wall completely (its a 3 step process so this will be divided by three)
|
|
var/tear_time
|
|
/// How much longer it takes to break reinforced walls
|
|
var/reinforced_multiplier
|
|
/// What interaction key do we use for our interaction
|
|
var/do_after_key
|
|
|
|
/datum/element/wall_tearer/Attach(datum/target, allow_reinforced = TRUE, tear_time = 2 SECONDS, reinforced_multiplier = 2, do_after_key = null)
|
|
. = ..()
|
|
if (!isliving(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
src.allow_reinforced = allow_reinforced
|
|
src.tear_time = tear_time
|
|
src.reinforced_multiplier = reinforced_multiplier
|
|
src.do_after_key = do_after_key
|
|
RegisterSignal(target, COMSIG_LIVING_UNARMED_ATTACK, PROC_REF(on_attacked_wall))
|
|
|
|
/datum/element/wall_tearer/Detach(datum/source)
|
|
. = ..()
|
|
UnregisterSignal(source, COMSIG_LIVING_UNARMED_ATTACK)
|
|
|
|
/// Try to tear up a wall
|
|
/datum/element/wall_tearer/proc/on_attacked_wall(mob/living/tearer, atom/target, proximity_flag)
|
|
SIGNAL_HANDLER
|
|
if (!proximity_flag)
|
|
return NONE
|
|
if (DOING_INTERACTION_WITH_TARGET(tearer, target) || (!isnull(do_after_key) && DOING_INTERACTION(tearer, do_after_key)))
|
|
tearer.balloon_alert(tearer, "busy!")
|
|
return COMPONENT_HOSTILE_NO_ATTACK
|
|
var/is_valid = validate_target(target, tearer)
|
|
if (is_valid != WALL_TEAR_ALLOWED)
|
|
return is_valid == WALL_TEAR_FAIL_CANCEL_CHAIN ? COMPONENT_HOSTILE_NO_ATTACK : NONE
|
|
INVOKE_ASYNC(src, PROC_REF(rip_and_tear), tearer, target)
|
|
return COMPONENT_HOSTILE_NO_ATTACK
|
|
|
|
/datum/element/wall_tearer/proc/rip_and_tear(mob/living/tearer, atom/target)
|
|
// We need to do this three times to actually destroy it
|
|
var/rip_time = (istype(target, /turf/closed/wall/r_wall) ? tear_time * reinforced_multiplier : tear_time) / 3
|
|
if (rip_time > 0)
|
|
tearer.visible_message(span_warning("[tearer] begins tearing through [target]!"))
|
|
playsound(tearer, 'sound/machines/airlock_alien_prying.ogg', vol = 100, vary = TRUE)
|
|
target.balloon_alert(tearer, "tearing...")
|
|
if (!do_after(tearer, delay = rip_time, target = target, interaction_key = do_after_key))
|
|
tearer.balloon_alert(tearer, "interrupted!")
|
|
return
|
|
// Might have been replaced, removed, or reinforced during our do_after
|
|
var/is_valid = validate_target(target, tearer)
|
|
if (is_valid != WALL_TEAR_ALLOWED)
|
|
return
|
|
tearer.do_attack_animation(target)
|
|
target.AddComponent(/datum/component/torn_wall)
|
|
is_valid = validate_target(target, tearer) // And now we might have just destroyed it
|
|
if (is_valid == WALL_TEAR_ALLOWED)
|
|
tearer.UnarmedAttack(target, proximity_flag = TRUE)
|
|
|
|
/// Check if the target atom is a wall we can actually rip up
|
|
/datum/element/wall_tearer/proc/validate_target(atom/target, mob/living/tearer)
|
|
if (!isclosedturf(target) || isindestructiblewall(target))
|
|
return WALL_TEAR_INVALID
|
|
|
|
var/reinforced = istype(target, /turf/closed/wall/r_wall)
|
|
if (!allow_reinforced && reinforced)
|
|
target.balloon_alert(tearer, "it's too strong!")
|
|
return WALL_TEAR_FAIL_CANCEL_CHAIN
|
|
return WALL_TEAR_ALLOWED
|
|
|
|
#undef WALL_TEAR_ALLOWED
|
|
#undef WALL_TEAR_INVALID
|
|
#undef WALL_TEAR_FAIL_CANCEL_CHAIN
|