mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-26 00:51:23 +00:00
a7e75d5a43
* Reaction & holder tweaks (#81545) ## About The Pull Request - Fixes #81537. For competing reactions where reaction B consumes the results formed from reaction A `total_step_added` yields values higher than the actual volume of products formed causing the reaction to end early leading to less volume of product formed as explained in the comment - Removes `update_total()` from instant reactions as it already does that for us making it a little faster - merges `remove_all_direct()` with `remove_all()` to reduce code as their functionalities are very similar ## Changelog 🆑 fix: multiple reactions occuring in the same holder like mixing drinks will yield correct reagent result volumes code: Removes `update_total()` from instant reactions improving performance slightly code: merges `remove_all_direct()` with `remove_all()` to reduce code size /🆑 * Reaction & holder tweaks --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>