FlufflesTheDog 4a9b6804b0 fix tile/rod/rcd multi-z hole repairs (#84255) ...

## About The Pull Request
Fixes some interactions with attempting to patch multi-z holes.

1. openspace clicks happen on different z levels, so it's inherently a
*ranged* interaction- it was being ignored due to using the non ranged
signal
2. RCD was lacking the open space click handler,
3. #77540 still exists to a degree, I've refactored the click handler to
use parse_caught_click_modifiers to always grab the tile you're aiming
at rather than going off of whatever item you happened to click on
4. handle_openspace_click was treating the modifiers list as the old
parameters list
## Why It's Good For The Game
fix bugs, being able to repair holes is a very important and time
sensitive task that needs to flow well, and not require pixel hunting
## Changelog
🆑
fix: multi-z hole repair works better, especially when the turf below is
blocked by items
/🆑

2024-06-25 00:34:17 -04:00

..

decals

Fixes decals compounding on shuttles (#83548)

2024-05-29 21:23:36 +02:00

food

Makes oven trays count as valid trays for cutting things on..... (#84224)

2024-06-23 16:10:48 -06:00

screentips

Standardizes object deconstruction throughout the codebase. (#82280)

2024-04-04 18:55:51 -06:00

_element.dm

Add a unit test to check that maploaded simple/basic mobs are in an environment they can survive in. (#82180)

2024-03-27 16:01:56 -06:00

ai_control_examine.dm

Monkey eyes fix and noticable organ display refactor; AI monkeys no longer catatonic (#82669)

2024-04-25 12:36:04 +01:00

ai_flee_while_injured.dm

Goats will randomly attack you (#78930)

2023-10-13 00:27:21 -06:00

ai_held_item.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

ai_retaliate.dm

Unit Tests for AI Planning Subtrees not having required element/component (#77539)

2023-08-12 23:08:43 +01:00

ai_swap_combat_mode.dm

Converts traders to basic mobs (#79187)

2023-10-31 01:49:56 +00:00

ai_target_damagesource.dm

…

amputating_limbs.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

animal_variety.dm

…

art.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

atmos_requirements.dm

Add a unit test to check that maploaded simple/basic mobs are in an environment they can survive in. (#82180)

2024-03-27 16:01:56 -06:00

atmos_sensitive.dm

Optimization pass focused on foam code (saves about 30% of cpu usage I think) (#76104)

2023-07-17 08:56:24 -07:00

attack_equip.dm

…

attack_zone_randomiser.dm

Ian and Runtime can lick your wounds (#83746)

2024-06-14 18:27:15 -07:00

backblast.dm

Pacifists can no longer endlessly spam rocket launcher backblasts (#82992)

2024-05-02 20:03:41 -06:00

bane.dm

…

basic_eating.dm

mothroaches in the wardrobe (#83695)

2024-06-19 15:38:29 -06:00

basic_health_examine.dm

Converts slimes to basic mobs (#82176)

2024-03-27 16:40:52 -06:00

beauty.dm

…

bed_tucking.dm

Autotucking On Map Load (#81782)

2024-03-03 19:55:23 +00:00

befriend_petting.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

blocks_explosives.dm

…

body_temp_sensitive.dm

Add a unit test to check that maploaded simple/basic mobs are in an environment they can survive in. (#82180)

2024-03-27 16:01:56 -06:00

bombable_turf.dm

Replace wall/indestructible/destructible typepath with mapping helper (#78365)

2023-09-16 19:30:30 +02:00

bonus_damage.dm

Spider Evolution - Young Spiders [Ready] (#76692)

2023-08-09 22:38:57 +02:00

bsa_blocker.dm

…

bugkiller_reagent.dm

…

bump_click.dm

…

can_barricade.dm

[NO GBP] Fix barricade description element spam (#78351)

2023-09-18 19:38:46 +02:00

can_shatter.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

caseless.dm

Different pen types have unique behavior when used in foam darts. (#79587)

2023-11-21 20:34:41 -05:00

chemical_transfer.dm

Code compression for reagent holder. Lowers plumbing reaction chamber tick usage (#79686)

2023-11-16 21:44:48 +01:00

chewable.dm

Removes remove_any from the game (#82020)

2024-03-17 15:52:41 -04:00

cleaning.dm

virtual pets (#81342)

2024-02-29 04:24:10 +00:00

cliff_walker.dm

Adds cliffs to icebox (#77062)

2023-07-28 14:13:43 +00:00

climbable.dm

Settler partially atomized into traits, ashwalkers given some settler traits (#84090)

2024-06-20 20:10:08 +01:00

connect_loc.dm

Fixes a decal hard del (#81093)

2024-01-26 02:23:24 +01:00

consumable_mob.dm

basic cats and mini kitchen helpers (#79800)

2023-11-28 21:51:37 -07:00

content_barfer.dm

Synchronise AI and Player basic mob melee behaviours (#78337)

2023-09-18 18:10:05 +02:00

corrupted_organ.dm

[no GBP] Corrupt organs check patient for Holy Water, not surgeon (#83500)

2024-05-29 14:22:25 -04:00

crackable.dm

…

crusher_loot.dm

…

cuffsnapping.dm

Removes final remnants of 'targetted' (#79626)

2023-11-11 07:46:02 -05:00

cult_eyes.dm

Fix cult halo and eyes affecting deconverted cultists (#80148)

2023-12-06 19:52:57 -07:00

cult_halo.dm

/icons/ folder cleansing crusade part 3 (#83420)

2024-05-25 21:08:08 -07:00

curse_announcement.dm

…

cursed.dm

…

damage_threshold.dm

Fix "/datum/element/damage_threshold looks unharmed!" (#80546)

2023-12-24 20:44:44 +00:00

dangerous_surgical_removal.dm

Bargain bin organ quirks: Prosthetic organ and Tin Man (#76498)

2023-07-08 00:31:43 +01:00

death_drops.dm

…

death_explosion.dm

…

death_gases.dm

…

delete_on_drop.dm

…

deliver_first.dm

…

dextrous.dm

Basic Guardians/Holoparasites (#79473)

2023-11-10 21:04:52 -07:00

diggable.dm

…

digitalcamo.dm

…

disarm_attack.dm

Disarm refactor, plus shoving people with shields (#80123)

2024-01-16 19:35:56 -06:00

door_pryer.dm

Targeting Datums Renamed (and global) (#79513)

2023-11-09 14:44:24 +00:00

drag_pickup.dm

Fix mousedrop handling on some atoms (#83971)

2024-06-13 23:45:58 -06:00

dryable.dm

Dead code removal, redundant text macros, drying rack now applies TRAIT_FOOD_CHEF_MADE. (#80677)

2024-01-04 00:10:36 +00:00

earhealing.dm

Robotic organ and disease improvements (#76766)

2023-07-21 11:55:29 +01:00

easily_fragmented.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

effect_trail.dm

transform the paper wizard from a simple to a basic (#76688)

2023-07-14 16:33:53 +01:00

ELEMENT_TEMPLATE.md

Revenants no longer make noise walking into gibs (#81420)

2024-02-13 17:07:16 +01:00

elevation.dm

Fix issues resulting from an elevated object being created inside of a non-turf atom (#83498)

2024-05-28 14:05:31 -06:00

embed.dm

Standing on structures such as crates, tables and bed will now look like it. (#79797)

2023-11-28 15:44:54 -07:00

empprotection.dm

Refactors chameleon actions, Adds chameleon outfit saving, Adds chameleon scanner (#77140)

2023-07-29 15:39:06 -06:00

envenomable_casing.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

eyestab.dm

…

falling_hazard.dm

…

firestacker.dm

…

floorloving.dm

…

footstep_override.dm

[NO GBP] Fixes catwalks over open space not making a sound when walked over. (#79738)

2023-11-15 18:31:01 -07:00

footstep.dm

Revert "Borg movement now has sounds" (#82795)

2024-04-21 17:13:23 -06:00

forced_gravity.dm

Attempts to fix an issue with gravity generators triggering CI failures (#76764)

2023-07-19 10:10:49 +02:00

frozen.dm

[NO GBP] Patches & renaming for NO_DECONSTRUCTION flag (#82547)

2024-04-10 18:58:11 -07:00

gags_recolorable.dm

New GaGs clothing: Part 1 - 'Dress'ing up! (#81785)

2024-03-15 17:23:47 -04:00

give_turf_traits.dm

Removes two redundant components (#76866)

2023-07-21 14:51:56 +02:00

gravedigger.dm

Graveyard update take two (#83567)

2024-06-02 02:52:52 +01:00

hat_wearer.dm

[no gbp] some medbot fixes (#80150)

2023-12-06 18:05:44 -07:00

haunted.dm

Fixes some AI related runtimes (#80828)

2024-01-09 14:06:16 -05:00

high_fiver.dm

…

honkspam.dm

…

hostile_machine.dm

Reworks targeting behavior to fall back onto proximity monitors. Refactors ai cooldowns a bit (#82640)

2024-04-16 17:37:46 -06:00

human_biter.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

immerse.dm

Revert "Makes immerse use weakrefs", prioritizing some ref removal lines instead. (#80707)

2024-01-17 04:38:13 -05:00

inverted_movement.dm

[NO GBP] The deathmatch modifiers modal menu can actually be opened now. (#82041)

2024-03-18 21:10:57 +01:00

item_fov.dm

…

item_scaling.dm

…

kneecapping.dm

Removes final remnants of 'targetted' (#79626)

2023-11-11 07:46:02 -05:00

kneejerk.dm

…

knockback.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

lazy_fishing_spot.dm

adds a new fish to lava and plasma rivers (#83146)

2024-05-22 23:11:45 -06:00

lifesteal.dm

…

light_blocking.dm

…

light_eaten.dm

Fixes complex lights not handling moving well, renames lighting defines (#81423)

2024-02-12 20:50:20 +01:00

light_eater.dm

Light eater can eat all lights again (#84162)

2024-06-24 16:21:25 -05:00

living_limb_initialiser.dm

Living Limb fixes (feat: Basic mobs attack random body zones again) (#82556)

2024-04-13 15:30:14 -06:00

loomable.dm

loopable looms (#79680)

2023-11-14 13:57:52 -07:00

lube_walking.dm

Changes how lube crawling works and fixes a bug with snails (#83238)

2024-05-16 23:46:03 +02:00

mirage_border.dm

Optimize mirage_border by converting it to an element and a movable (#77137)

2023-08-07 12:19:10 +01:00

mob_access.dm

minebot buff (#82001)

2024-03-29 22:26:35 -06:00

mob_grabber.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

mob_killed_tally.dm

…

move_force_on_death.dm

[no gbp] fixes not being able to walk over mook corpses and turns it all to a element (#79054)

2023-10-21 13:39:45 -04:00

movement_turf_changer.dm

Splits placeontop proc (#79702)

2023-11-19 04:58:31 +01:00

movetype_handler.dm

…

nerfed_pulling.dm

…

noisy_movement.dm

…

noticable_organ.dm

Monkey eyes fix and noticable organ display refactor; AI monkeys no longer catatonic (#82669)

2024-04-25 12:36:04 +01:00

obj_regen.dm

…

openspace_item_click_handler.dm

fix tile/rod/rcd multi-z hole repairs (#84255)

2024-06-25 00:34:17 -04:00

ore_collecting.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

organ_set_bonus.dm

…

permanent_fire_overlay.dm

Fix Flaky Failure From Fire (#81399)

2024-02-10 13:39:01 -08:00

pet_bonus.dm

Removes timeout_mod arg from add_mood_effect (#80964)

2024-01-16 20:57:42 +01:00

plant_backfire.dm

…

point_of_interest.dm

…

poster_tearer.dm

Regal Rats can now tear down posters (#82673)

2024-04-17 18:57:35 +01:00

prevent_attacking_of_types.dm

…

proficient_miner.dm

lavaland raptors (#82537)

2024-05-16 19:54:00 -07:00

projectile_drop.dm

Fixing embedding for projectiles. (#77674)

2023-08-20 16:40:03 +00:00

projectile_shield.dm

…

radiation_protected_clothing.dm

…

radioactive.dm

[NO-GBP] Optimizes rad nebula (#77014)

2023-07-25 15:55:10 +02:00

ranged_armour.dm

adds a new fish to lava and plasma rivers (#83146)

2024-05-22 23:11:45 -06:00

relay_attackers.dm

Replace Heretic Phobia with Cursed Organs (#83082)

2024-05-08 19:40:16 -06:00

ridable.dm

Makes it EVEN EASIER to work with atom item interactions ft. "Leaf and Branch" & "Death to Chains" (#82625)

2024-04-18 05:17:39 -07:00

rust.dm

[NO GBP] Post-Rust Heretic's Rework adjustments. (#83765)

2024-06-07 13:35:39 -04:00

selfknockback.dm

Afterattack is dead, long live Afterattack (#83818)

2024-06-11 21:58:09 -07:00

series.dm

…

sideway_movement.dm

[NO GBP] fixes crab walking (#78648)

2023-09-28 13:42:23 -06:00

simple_flying.dm

…

skill_reward.dm

Items in your hands can catch fire (#83867)

2024-06-19 12:15:27 +12:00

skittish.dm

minor changes to living and mob vars (#77820)

2023-08-26 02:24:15 +01:00

soft_landing.dm

…

spooky.dm

Spooky element fixes (#83795)

2024-06-08 19:26:03 -04:00

squish_sound.dm

Revenants no longer make noise walking into gibs (#81420)

2024-02-13 17:07:16 +01:00

squish.dm

…

strippable.dm

[NO GBP] Piggyback ,strip menu & Paraplegic mouse drop fixes (#84268)

2024-06-24 16:04:36 -05:00

structure_repair.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

swabbable.dm

…

temporary_atom.dm

Various spider fixes (#76528)

2023-07-05 19:26:45 -06:00

tenacious.dm

…

tiny_mob_hunter.dm

…

tool_flash.dm

Fixes tool-based flashes being stuck at intensity 1 (#83703)

2024-06-06 00:41:40 -04:00

tool_renaming.dm

Refactor renaming UNIQUE_RENAME items from the pen to an element (#82491)

2024-04-12 03:30:32 +00:00

toy_talk.dm

Let's you talk through action figures, plushies, and toy mechs with .l and .r. Also a big clean up of say because its support for non-mobs was lackluster. (#81848)

2024-03-07 09:21:12 -07:00

turf_transparency.dm

Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse (#77786)

2023-09-19 01:06:08 +00:00

undertile.dm

Invisibility refactor (#78908)

2023-10-17 13:07:31 -06:00

unfriend_attacker.dm

…

update_icon_blocker.dm

…

update_icon_updates_onmob.dm

…

uplink_reimburse.dm

Adds a signal to buying items from the uplink (& fixes TC misinfo) (#81372)

2024-02-10 18:57:19 +01:00

venomous.dm

Throwing a bee at someone injects reagents (#80354)

2023-12-17 01:10:06 +01:00

volatile_gas_storage.dm

…

waddling.dm

Cardboard cutouts are now tactical. (#81245)

2024-02-17 17:17:18 +00:00

wall_engraver.dm

…

wall_smasher.dm

Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs (#78991)

2023-10-15 22:25:19 -06:00

wall_tearer.dm

basic gutlunchers and ashwalker ranching (#79508)

2023-11-13 01:20:19 -07:00

wall_walker.dm

Basic Constructs: parent type + Harvester (#78807)

2023-10-10 15:55:09 -06:00

watery_tile.dm

Water tiles now put out burning atoms (#82735)

2024-04-18 19:53:57 -04:00

weapon_description.dm

Adds p_They (and friends) for capitalized pronoun helpers (#76910)

2023-07-17 22:55:58 -07:00

weather_listener.dm

Shapechange health transfer tweaks (#79009)

2023-10-26 01:30:53 +00:00

web_walker.dm

…

wheel.dm

Basic Mob Raw Prophet (#78733)

2023-10-03 14:26:50 -06:00

window_smash.dm

Tram mob throwing adjustments (#81617)

2024-02-27 01:33:12 +00:00