mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-11 01:13:18 +00:00
8a6f660141
## About The Pull Request Fixes #80534 ``` [2023-12-23 19:23:03.446] RUNTIME: runtime error: Cannot read "sentience fun balloon".layer - proc name: poll candidates (/datum/controller/subsystem/polling/proc/poll_candidates) - source file: code/controllers/subsystem/polling.dm,90 - usr: Bob Stange (/mob/dead/observer) - src: Polling (/datum/controller/subsystem/polling) - usr.loc: the floor (166,47,1) (/turf/open/floor/iron) - call stack: - Polling (/datum/controller/subsystem/polling): poll candidates("Would you like to be test?", "Sentience Potion Spawn", "Sentience Potion Spawn", 100, "shuttle_denizens", the sentience fun balloon (/obj/effect/fun_balloon/sentience), /list (/list), "sentience fun balloon", "Sentience Potion Spawn") ... ``` Classic off-by-one error, except instead of a mathematical error it was a logical error. `/datum/controller/subsystem/polling/proc/poll_ghost_candidates_for_mobs(...)` called `poll_ghost_candidates` with an incorrect number of args, omitting the `flashwindow` arg and causing `pic_source` to be passed as `flashwindow` and `role_name_text` to be passed as `pic_source`. Since `role_name_text` is a string, this causes the above runtime as the code tries to access the `.layer` member of the string. Which strings don't have. Because they're strings. I added the missing `flashwindow` arg and tidied up the base proc call a touch back at the sentience balloon layer, since I noticed it was using named args out of order which - while valid - could cause issues in any future refactor or copypasted code. ## Why It's Good For The Game Sentience Fun Balloons work again! ## Changelog 🆑 fix: Fixed an issue with polling ghost roles to control multiple mobs that prevented Sentience Fun Balloons from working as intended. /🆑