mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-11 09:22:41 +00:00
6c30cf4ca6
What it says on the tin. As far as I've been able to tell nothing is negatively affected by this removal. Humans seem to work fine, monkeys seem to work fine, xenos seem to work fine. Even the CI was happy in my local unit test runs! Did I miss anything? The proc seems to serve no purpose and, what is more problematic, all it does is already done by `/datum/species/regenerate_organs()`, which creates and inserts all organs yada yada. There's *currently* no problems caused by this in the codebase as far as I'm aware but it could/will cause various errors in the future. Case and point (found on a downstream): if you ever wanted a species/human subtype to have a certain brain trauma roundstart you'd get errors every time one was created. Why? `The regenerate_organs()` proc is called first as part of `on_species_gain()` when the humans's species is set and afterwards we call `create_internal_organs()` which runs `Insert()` for every organ a *second* time and, in the case of the brain, would trip an error due to finding brain traumas whose owner is the person the brain is being inserted into.