mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 09:42:29 +00:00
79b00baad2
## About The Pull Request
As the title says.
`init_order` is no more, subsystems ordering now depends on their
declared dependencies.
Subsystems can now declare which other subsystems need to init before
them using a list and the subsystem's typepath
I.e.
```dm
dependencies = list(
/datum/controller/subsystem/atoms,
/datum/controller/subsystem/mapping
)
```
The reverse can also be done, if a subsystem must initialize after your
own:
```dm
dependents = list(
/datum/controller/subsystem/atoms
)
```
Cyclical dependencies are not allowed and will throw an error on
initialization if one is found.
There's also a debug tool to visualize the dependency graph, although
it's a bit basic:
Subsystem load ordering can still be controlled using `init_stage`, some
subsystems use this in cases where they must initialize first or last
regardless of dependencies. An error will be thrown if a subsystem has
an `init_stage` before one of their dependencies.
## Why It's Good For The Game
Makes dealing with subsystem dependencies easier, and reduces the chance
of making a dependency error when needing to shift around subsystem
inits.
## Changelog
🆑
refactor: Refactored subsystem initialization
/🆑
28 lines
1.1 KiB
Plaintext
28 lines
1.1 KiB
Plaintext
#define INIT_PROFILE_NAME "init_profiler.json"
|
|
|
|
///Subsystem exists so we can separately log init time costs from the costs of general operation
|
|
///Hopefully this makes sorting out what causes problems when easier
|
|
SUBSYSTEM_DEF(init_profiler)
|
|
name = "Init Profiler"
|
|
init_stage = INITSTAGE_LAST
|
|
flags = SS_NO_FIRE
|
|
|
|
/datum/controller/subsystem/init_profiler/Initialize()
|
|
if(CONFIG_GET(flag/auto_profile))
|
|
write_init_profile()
|
|
return SS_INIT_SUCCESS
|
|
|
|
/datum/controller/subsystem/init_profiler/proc/write_init_profile()
|
|
var/current_profile_data = world.Profile(PROFILE_REFRESH, format = "json")
|
|
CHECK_TICK
|
|
|
|
if(!length(current_profile_data)) //Would be nice to have explicit proc to check this
|
|
stack_trace("Warning, profiling stopped manually before dump.")
|
|
var/prof_file = file("[GLOB.log_directory]/[INIT_PROFILE_NAME]")
|
|
if(fexists(prof_file))
|
|
fdel(prof_file)
|
|
WRITE_FILE(prof_file, current_profile_data)
|
|
world.Profile(PROFILE_CLEAR) //Now that we're written this data out, dump it. We don't want it getting mixed up with our current round data
|
|
|
|
#undef INIT_PROFILE_NAME
|