Files
Bubberstation/code/modules/client/preferences/middleware/quirks.dm
FlufflesTheDog 5bc18586a7 System for restricting quirks based on species, no more blood deficiency on bloodless species (#90326)
## About The Pull Request
Quirks can now define if they're "species appropriate," where the base
proc's behavior is simply "does this species already have the quirk's
main trait"
I am unsure if that on its own imposes any new restrictions, currently.

Additionally, blood deficiency cannot be picked on any species without
blood or that doesn't breathe.
I'm sure there's more that might make sense, I'm open to suggestions

Alternative to #90238
## Why It's Good For The Game
Currently, reduces the possibility of taking something like blood
deficiency on a race which suffers no downside from it in order to get
free positive quirks.
Future-ly, potentially allows quirks exclusive to only a select few
species as offered by #90238
## Changelog
🆑
fix: Species without blood can no longer be blood deficient
/🆑
2025-04-05 19:42:52 +02:00

143 lines
4.9 KiB
Plaintext

/// Middleware to handle quirks
/datum/preference_middleware/quirks
var/tainted = FALSE
action_delegations = list(
"give_quirk" = PROC_REF(give_quirk),
"remove_quirk" = PROC_REF(remove_quirk),
)
/datum/preference_middleware/quirks/pre_set_preference(mob/user, preference, value)
if(preference != "species")
return
var/list/incompatible_quirks
var/selected_species_type = GLOB.species_list[value]
for(var/quirk_name in preferences.all_quirks)
var/quirk_path = SSquirks.quirks[quirk_name]
var/datum/quirk/quirk_prototype = SSquirks.quirk_prototypes[quirk_path]
if(!quirk_prototype.is_species_appropriate(selected_species_type))
LAZYADD(incompatible_quirks, quirk_name)
if(!LAZYLEN(incompatible_quirks))
return
var/list/message = list("The following quirks are incompatible with your selected species and will be removed: [incompatible_quirks.Join(", ")].")
if(CONFIG_GET(flag/disable_quirk_points))
message += "Would you like to continue?"
else
message += "If you do not have enough points to cover the removed quirks, your quirks will be reset. Would you like to continue?"
var/response = tgui_alert(user, message.Join(" "), "Quirks Incompatible", list("Yes", "No"))
if(response != "Yes")
return TRUE
/datum/preference_middleware/quirks/post_set_preference(mob/user, preference, value)
if(preference != "species")
return
tainted = TRUE
preferences.validate_quirks()
/datum/preference_middleware/quirks/proc/get_species_compatibility()
var/list/species_blacklist = list()
var/datum/species/mob_species = preferences.read_preference(/datum/preference/choiced/species)
for(var/datum/quirk/quirk_type as anything in SSquirks.quirk_prototypes)
if(!SSquirks.quirk_prototypes[quirk_type].is_species_appropriate(mob_species))
species_blacklist += quirk_type::name
return species_blacklist
/datum/preference_middleware/quirks/get_ui_static_data(mob/user)
if (preferences.current_window != PREFERENCE_TAB_CHARACTER_PREFERENCES)
return list()
var/list/data = list()
data["selected_quirks"] = get_selected_quirks()
data["species_disallowed_quirks"] = get_species_compatibility()
return data
/datum/preference_middleware/quirks/get_ui_data(mob/user)
var/list/data = list()
if (tainted)
tainted = FALSE
data["selected_quirks"] = get_selected_quirks()
data["species_disallowed_quirks"] = get_species_compatibility()
return data
/datum/preference_middleware/quirks/get_constant_data()
var/list/quirk_info = list()
var/list/quirks = SSquirks.get_quirks()
var/max_positive_quirks = CONFIG_GET(number/max_positive_quirks)
var/positive_quirks_disabled = max_positive_quirks == 0
for (var/quirk_name in quirks)
var/datum/quirk/quirk = quirks[quirk_name]
if(positive_quirks_disabled && initial(quirk.value) > 0)
continue
var/datum/quirk_constant_data/constant_data = GLOB.all_quirk_constant_data[quirk]
var/list/datum/preference/customization_options = constant_data?.get_customization_data()
quirk_info[sanitize_css_class_name(quirk_name)] = list(
"description" = initial(quirk.desc),
"icon" = initial(quirk.icon),
"name" = quirk_name,
"value" = initial(quirk.value),
"customizable" = constant_data?.is_customizable(),
"customization_options" = customization_options,
)
return list(
"max_positive_quirks" = max_positive_quirks,
"quirk_info" = quirk_info,
"quirk_blacklist" = GLOB.quirk_string_blacklist,
"points_enabled" = !CONFIG_GET(flag/disable_quirk_points),
)
/datum/preference_middleware/quirks/on_new_character(mob/user)
tainted = TRUE
/datum/preference_middleware/quirks/proc/give_quirk(list/params, mob/user)
var/quirk_name = params["quirk"]
preferences.validate_quirks()
var/list/new_quirks = preferences.all_quirks | quirk_name
if (SSquirks.filter_invalid_quirks(new_quirks) != new_quirks)
// If the client is sending an invalid give_quirk, that means that
// something went wrong with the client prediction, so we should
// catch it back up to speed.
preferences.update_static_data(user)
return TRUE
preferences.all_quirks = new_quirks
preferences.character_preview_view?.update_body()
return TRUE
/datum/preference_middleware/quirks/proc/remove_quirk(list/params, mob/user)
var/quirk_name = params["quirk"]
var/list/new_quirks = preferences.all_quirks - quirk_name
if ( \
!(quirk_name in preferences.all_quirks) \
|| SSquirks.filter_invalid_quirks(new_quirks) != new_quirks \
)
// If the client is sending an invalid remove_quirk, that means that
// something went wrong with the client prediction, so we should
// catch it back up to speed.
preferences.update_static_data(user)
return TRUE
preferences.all_quirks = new_quirks
preferences.character_preview_view?.update_body()
return TRUE
/datum/preference_middleware/quirks/proc/get_selected_quirks()
var/list/selected_quirks = list()
for (var/quirk in preferences.all_quirks)
selected_quirks += sanitize_css_class_name(quirk)
return selected_quirks