mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-27 18:12:00 +00:00
e65a48e91f
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761) Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks. Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work. This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping. To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway. Requested by @optimumtact. Changelog cl admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again. /cl * Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
36 lines
986 B
Plaintext
36 lines
986 B
Plaintext
/datum/element/snailcrawl
|
|
element_flags = ELEMENT_DETACH
|
|
|
|
/datum/element/snailcrawl/Attach(datum/target)
|
|
. = ..()
|
|
if(!ismovable(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
var/P
|
|
if(iscarbon(target))
|
|
P = .proc/snail_crawl
|
|
else
|
|
P = .proc/lubricate
|
|
RegisterSignal(target, COMSIG_MOVABLE_MOVED, P)
|
|
|
|
/datum/element/snailcrawl/Detach(mob/living/carbon/target)
|
|
. = ..()
|
|
UnregisterSignal(target, COMSIG_MOVABLE_MOVED)
|
|
if(istype(target))
|
|
target.remove_movespeed_modifier(/datum/movespeed_modifier/snail_crawl)
|
|
|
|
/datum/element/snailcrawl/proc/snail_crawl(mob/living/carbon/snail)
|
|
SIGNAL_HANDLER
|
|
|
|
if(snail.resting && !snail.buckled && lubricate(snail))
|
|
snail.add_movespeed_modifier(/datum/movespeed_modifier/snail_crawl)
|
|
else
|
|
snail.remove_movespeed_modifier(/datum/movespeed_modifier/snail_crawl)
|
|
|
|
/datum/element/snailcrawl/proc/lubricate(atom/movable/snail)
|
|
SIGNAL_HANDLER
|
|
|
|
var/turf/open/OT = get_turf(snail)
|
|
if(istype(OT))
|
|
OT.MakeSlippery(TURF_WET_LUBE, 20)
|
|
return TRUE
|