mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-30 11:01:35 +00:00
777a8ef8f6
## About The Pull Request In this pr we make it so, instead of doing an early return, whispers you cannot hear will display a feedback message along the lines of: `Angel Randolph says something, but you are too far away to understand him.` As long as you are capable of seeing them say something. This includes signing, as it uses the same logic. If they're not signing and you cannot hear at all, then it skips to the normal deaf messages. <details> <summary>Example Test Images</summary> ### explanation: The number after each message denotes the distance between speaker and listener. The first image is from the speaker's pov, the second from the listener's. ### no blindfold, no earmuffs: no signing   signing   ### no blindfold, earmuffs: no signing   signing   ### blindfold, no earmuffs: no signing   signing   ### blindfold, earmuffs: no signing   </details> ## Why It's Good For The Game Currently, someone whispering grants zero feedback to listeners who are beyond 2 tiles (without good hearing), all they get is that the speaker's typing indicator disappeared. This makes it look indistinguishable from the speaker just having backspaced their message. This is _especially_ annoying with soft-spoken, as it tends to cause other players to disengage, because to them you just didn't press enter if they left your immediate range before you finished speaking. But even outside of that, arguably, even if you couldn't _hear_ it, you should be able to _see_ the movements of them speaking. And really, I just think that it'd lead to fun interactions if you could grumble to yourself or whisper amongst each other and have people actually know you're up to _something_. ## Changelog 🆑 add: You can now see people whispering, even if you cannot hear what they're saying, unless you are blind (obviously). The speaker wearing something that covers their mouth, being invisible, or being inside of something counteracts this. /🆑