Files
Bubberstation/code/modules/unit_tests/cardboard_cutouts.dm
SkyratBot db625af910 [MIRROR] Optimize cardboard cutouts saving 1.5s+ on init times [MDB IGNORE] (#19435)
* Optimize cardboard cutouts saving 1.5s+ on init times (#73404)

New regression in init times. Closes
https://github.com/tgstation/dev-cycles-initiative/issues/32. CC @ Fikou

- Instead of creating a human and icon for *every* cardboard cutout when
initialized, only creates the one we're actually using. When you're
about to use a crayon, creates all of them.
- Instead of using getFlatIcon, uses appearances directly.

* Optimize cardboard cutouts saving 1.5s+ on init times

---------

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2023-02-19 22:52:00 +00:00

28 lines
968 B
Plaintext

/// Validates that cardboard cutouts have the proper icons
/datum/unit_test/cardboard_cutouts
/datum/unit_test/cardboard_cutouts/Run()
var/obj/item/cardboard_cutout/normal_cutout = new
test_screenshot("normal_cutout", getFlatIcon(normal_cutout))
var/obj/item/cardboard_cutout/nuclear_operative/nukie_cutout = new
test_screenshot("nukie_cutout", getFlatIcon(nukie_cutout))
nukie_cutout.push_over()
test_screenshot("nukie_cutout_pushed", getFlatIcon(nukie_cutout))
#if DM_VERSION >= 515
// This is the only reason we're testing xenomorphs.
// Making a custom subtype with direct_icon is hacky.
ASSERT(!isnull(/datum/cardboard_cutout/xenomorph_maid::direct_icon))
#endif
var/obj/item/cardboard_cutout/xenomorph/xenomorph_cutout = new
test_screenshot("xenomorph_cutout", getFlatIcon(xenomorph_cutout))
/obj/item/cardboard_cutout/nuclear_operative
starting_cutout = "Nuclear Operative"
/obj/item/cardboard_cutout/xenomorph
starting_cutout = "Xenomorph"