mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-06-05 22:31:04 +01:00
92fe2245df
## About The Pull Request Instead of simply being qdel'ed, shattered items have their deconstruct proc called (with flags set to prevent items from being dropped in the process). This means that if an object has code that should run before it's destroyed in order to maintain in-game consistency, that will be called instead of ignored. As a result: - Internals tanks release gasses inside of them (what I wanted to fix) - Frozen containers only destroy themselves, not everything inside of them (unintended side effect -- I think it's good but others might disagree) - Grenades detonate (unintended side effect -- can be disabled by changing the disassembled flag to true instead of false) - Gas crystals release their contents (because theyre grenades) - Hot Ice does NOT release anything, since it's a datum and not an object Also, fixes a potential bug where holodeck canisters wouldn't be destroyed when their deconstruct was called, making them (possibly?) indestructible. I doubt this would ever have shown up, but... it's fixed now! ## Why It's Good For The Game Fixes https://github.com/tgstation/tgstation/issues/71121, adds potential support for similar future cases. Fixes an issue where holodeck canisters (should those ever exist) would be indestructible. ## Changelog 🆑 fix: frozen gas tanks now release their contents upon shattering fix: holodeck gas tanks can now be deconstructed /🆑